Repository navigation
fix(config): enforce Timmy validation at startup and on settings writes - #1113
Merged
Merged
Conversation
Refuse to start in production when the dump flag is set or llm_provider is invalid, checking both the env/YAML config and the DB-resolved effective Timmy config. Reject the same values on settings writes via a single key-to-validator map in the settings service (400 invalid_input). Fixes #1102 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n bad dump flag Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Refs #1102 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm_provideris invalid. It checks both the env/YAML config and the effective Timmy config resolved from the database.invalid_inputthrough one key-to-validator map inSettingsService.Set. A malformed bool fails closed.Set).Test plan
make verifyFixes #1102
🤖 Generated with Claude Code
https://claude.ai/code/session_015szS68rpMLaq712AFsbMfr