fix: address #1103-#1109 and #1115

api-schema/tmi-openapi.json

@@ -6273,8 +6273,8 @@
             },
             "path": {
               "type": "string",
-              "description": "JSON path to target",
-              "pattern": "^(/[^/]*)*$",
+              "description": "JSON Pointer (RFC 6901) to the target; must start with \"/\" (the document root \"\" is not allowed)",
+              "pattern": "^(/[^/]*)+$",
               "maxLength": 512
             },
             "value": {
@@ -6322,6 +6322,12 @@
                   }
                 }
               ]
+            },
+            "from": {
+              "type": "string",
+              "description": "JSON Pointer (RFC 6901) to the source location. Required for move and copy operations, ignored otherwise; must start with \"/\".",
+              "pattern": "^(/[^/]*)+$",
+              "maxLength": 512
             }
           },
           "required": [
@@ -8243,7 +8249,13 @@
             "maxLength": 128,
             "pattern": "^[^\\x00-\\x1F]*$",
             "description": "Survey status: active surveys appear in intake, inactive are hidden but editable, archived are read-only and preserved for historical reference",
-            "nullable": true
+            "nullable": true,
+            "enum": [
+              "active",
+              "inactive",
+              "archived"
+            ],
+            "x-go-type": "string"
           },
           "settings": {
             "$ref": "#/components/schemas/SurveySettings"
@@ -14391,7 +14403,7 @@
       "IsConfidentialQueryParam": {
         "name": "is_confidential",
         "in": "query",
-        "description": "Filter by secret_project flag",
+        "description": "Filter survey responses by their is_confidential flag, intersected with the caller's reviewer scope",
         "schema": {
           "type": "boolean"
         }
@@ -14412,7 +14424,13 @@
         "schema": {
           "type": "string",
           "maxLength": 128,
-          "pattern": "^[^\\x00-\\x1F]*$"
+          "pattern": "^[^\\x00-\\x1F]*$",
+          "enum": [
+            "active",
+            "inactive",
+            "archived"
+          ],
+          "x-go-type": "string"
         }
       },
       "SurveyId": {

api/client_credentials_handlers.go

@@ -19,7 +19,7 @@ import (
 
 // CreateCurrentUserClientCredential handles POST /me/client_credentials
 // Creates a new OAuth 2.0 client credential for machine-to-machine authentication
-// SEM@32e22d40fa43dfa14fa39b14713e41c740ebe026: build a client credential for the authenticated user, enforcing authorization, quota, and direct_write rules (writes DB)
+// SEM@fd749f0ab4b11da6219ce6594a51301843131dc9: build a client credential for the authenticated user, enforcing quota and conflict rules (writes DB)
 func (s *Server) CreateCurrentUserClientCredential(c *gin.Context) {
 	logger := slogging.Get().WithContext(c)
 
@@ -161,32 +161,7 @@ func (s *Server) CreateCurrentUserClientCredential(c *gin.Context) {
 		ExpiresAt:   timeFromPtr(req.ExpiresAt),
 	})
 	if err != nil {
-		if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
-			logger.Debug("Request cancelled during credential create: %v", err)
-			return
-		}
-		if errors.Is(err, dberrors.ErrDuplicate) || errors.Is(err, dberrors.ErrConstraint) {
-			logger.Warn("Client credential creation failed due to constraint: %v", err)
-			c.JSON(http.StatusConflict, Error{
-				Error:            ErrorError(errcode.Conflict),
-				ErrorDescription: "A client credential with these details already exists",
-			})
-			return
-		}
-		if errors.Is(err, dberrors.ErrTransient) {
-			logger.Warn("Transient DB error creating client credential: %v", err)
-			c.Header("Retry-After", "30")
-			c.JSON(http.StatusServiceUnavailable, Error{
-				Error:            ErrorError(errcode.ServiceUnavailable),
-				ErrorDescription: "Database temporarily unavailable, please retry",
-			})
-			return
-		}
-		logger.Error("Failed to create client credential for user %s: %v", ownerUUID, err)
-		c.JSON(http.StatusInternalServerError, Error{
-			Error:            ErrorError(errcode.ServerError),
-			ErrorDescription: "Failed to create client credential",
-		})
+		respondClientCredentialCreateError(c, logger, ownerUUID, err)
 		return
 	}
 
@@ -209,9 +184,40 @@ func (s *Server) CreateCurrentUserClientCredential(c *gin.Context) {
 	c.JSON(http.StatusCreated, apiResp)
 }
 
+// respondClientCredentialCreateError maps a credential create failure to a documented response.
+// SEM@4f8575cbdd6a06b8391482229de6c8cb075359d3: map a client credential create error to its documented HTTP error response
+func respondClientCredentialCreateError(c *gin.Context, logger *slogging.ContextLogger, ownerUUID uuid.UUID, err error) {
+	if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
+		logger.Debug("Request canceled during credential create: %v", err)
+		return
+	}
+	if errors.Is(err, dberrors.ErrDuplicate) || errors.Is(err, dberrors.ErrConstraint) {
+		logger.Warn("Client credential creation failed due to constraint: %v", err)
+		c.JSON(http.StatusBadRequest, Error{
+			Error:            ErrorError(errcode.InvalidInput),
+			ErrorDescription: "The client credential could not be created with the supplied details",
+		})
+		return
+	}
+	if errors.Is(err, dberrors.ErrTransient) {
+		logger.Warn("Transient DB error creating client credential: %v", err)
+		c.Header("Retry-After", "30")
+		c.JSON(http.StatusServiceUnavailable, Error{
+			Error:            ErrorError(errcode.ServiceUnavailable),
+			ErrorDescription: "Database temporarily unavailable, please retry",
+		})
+		return
+	}
+	logger.Error("Failed to create client credential for user %s: %v", ownerUUID, err)
+	c.JSON(http.StatusInternalServerError, Error{
+		Error:            ErrorError(errcode.ServerError),
+		ErrorDescription: "Failed to create client credential",
+	})
+}
+
 // ListCurrentUserClientCredentials handles GET /me/client_credentials
 // Retrieves all client credentials owned by the authenticated user (without secrets)
-// SEM@32e22d40fa43dfa14fa39b14713e41c740ebe026: list the authenticated user's client credentials with pagination, omitting secrets (reads DB)
+// SEM@db94db3c8118cffb5220bf9a44c2fde0ada20427: list the authenticated user's client credentials with pagination, omitting secrets (reads DB)
 func (s *Server) ListCurrentUserClientCredentials(c *gin.Context, params ListCurrentUserClientCredentialsParams) {
 	logger := slogging.Get().WithContext(c)
 	userUUID := c.GetString("userInternalUUID")
@@ -317,7 +323,7 @@ func (s *Server) ListCurrentUserClientCredentials(c *gin.Context, params ListCur
 
 // DeleteCurrentUserClientCredential handles DELETE /me/client_credentials/{credential_id}
 // Permanently deletes a client credential
-// SEM@9750a568b8ffb60cfd241d61263b7e23f990899e: delete and revoke a client credential owned by the authenticated user (writes DB)
+// SEM@db94db3c8118cffb5220bf9a44c2fde0ada20427: delete and revoke a client credential owned by the authenticated user (writes DB)
 func (s *Server) DeleteCurrentUserClientCredential(c *gin.Context, credentialId openapi_types.UUID) {
 	logger := slogging.Get().WithContext(c)
 	userUUID := c.GetString("userInternalUUID")

api/client_credentials_handlers_test.go

@@ -10,6 +10,8 @@ import (
 	"testing"
 	"time"
 
+	"github.com/ericfitz/tmi/internal/dberrors"
+	"github.com/ericfitz/tmi/internal/slogging"
 	"github.com/gin-gonic/gin"
 	"github.com/google/uuid"
 	"github.com/stretchr/testify/assert"
@@ -754,3 +756,32 @@ func TestCreateCurrentUserClientCredential_AddonLink(t *testing.T) {
 	w, _ = post(`{"name":"tf-wh","direct_write":true,"addon_id":"` + knownAddon.String() + `"}`)
 	assert.Equal(t, http.StatusServiceUnavailable, w.Code)
 }
+
+// #1105: POST /me/client_credentials documents no 409, so a store constraint or
+// duplicate error must map to a documented code (400 invalid_input).
+func TestRespondClientCredentialCreateError(t *testing.T) {
+	gin.SetMode(gin.TestMode)
+
+	cases := []struct {
+		name       string
+		err        error
+		wantStatus int
+		wantCode   string
+	}{
+		{"Constraint", fmt.Errorf("insert: %w", dberrors.ErrConstraint), http.StatusBadRequest, "invalid_input"},
+		{"Duplicate", fmt.Errorf("insert: %w", dberrors.ErrDuplicate), http.StatusBadRequest, "invalid_input"},
+		{"Transient", fmt.Errorf("insert: %w", dberrors.ErrTransient), http.StatusServiceUnavailable, "service_unavailable"},
+		{"Unknown", fmt.Errorf("boom"), http.StatusInternalServerError, "server_error"},
+	}
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			c, w := CreateTestGinContextWithBody("POST", "/me/client_credentials", "application/json", []byte(testCredBody))
+			respondClientCredentialCreateError(c, slogging.Get().WithContext(c), uuid.New(), tc.err)
+
+			assert.Equal(t, tc.wantStatus, w.Code)
+			var errResp Error
+			require.NoError(t, json.Unmarshal(w.Body.Bytes(), &errResp))
+			assert.Equal(t, tc.wantCode, string(errResp.Error))
+		})
+	}
+}

api/config_handlers_test.go

@@ -1711,6 +1711,11 @@ func TestUpdateSystemSetting_TimmyValidation(t *testing.T) {
 		assert.Equal(t, http.StatusBadRequest, w.Code)
 		assert.Contains(t, w.Body.String(), "invalid_input")
 	})
+	t.Run("negative max tokens is 400", func(t *testing.T) {
+		w := put(t, "dev", "timmy.llm_max_tokens", `{"value": "-5", "type": "int"}`)
+		assert.Equal(t, http.StatusBadRequest, w.Code)
+		assert.Contains(t, w.Body.String(), "invalid_input")
+	})
 	t.Run("development dump flag true is 200", func(t *testing.T) {
 		w := put(t, "dev", "timmy.dump_extracted_text_to_note", `{"value": "true", "type": "bool"}`)
 		assert.Equal(t, http.StatusOK, w.Code)