Repository navigation
rpc/mcp: propagate eth_syncing errors in network status - #25451
Merged
AskAlexSharov merged 1 commit intoOct 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change to surface eth_syncing failures rather than a misleading synced status.
No open issues 🎉
What changed in this PR
This PR prevents the MCP network-status resource from reporting syncing: false when the eth_syncing RPC fails. Successful responses and partial-data handling for other fields remain unchanged.
Changes:
- Return
eth_syncingerrors with the method name while preserving the underlying error. - Add a regression test that checks an RPC failure returns an error and no resource contents.
| File | Description |
|---|---|
rpc/mcp/resources.go |
Propagates eth_syncing errors from the network-status handler. |
rpc/mcp/resources_test.go |
Tests that an RPC failure cannot produce a misleading synced status. |
Review effort: Balanced
AskAlexSharov
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
erigon://network/statuscurrently ignores aneth_syncingRPC error and serializes the defaultsyncing: false. That makes an unavailable sync status look like a fully synced node.Return the RPC error with its method name instead. Successful
falseand progress-object responses are unchanged. This does not change how the other fields handle partial data.Verification
TestResourceNetworkStatusDoesNotClaimSyncedOnRPCFailure; it failed on unmodifiedmainand passes with this change.go test ./rpc/mcp -count=1make lintmake erigon integration