Add C++ wrapper Simd::SynetAdd16b - #858
Merged
Merged
Conversation
Introduce a public analogue of Synet::Add16b that wraps SimdSynetAdd16bInit and SimdSynetAdd16bForward, with Doxygen docs and a CheckCpp verification test. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
ermig1979
marked this pull request as ready for review
August 13, 2026 12:32
Keep SVE2 QuantizedMergedConvolution release notes from dev and the Simd::SynetAdd16b wrapper entry. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a public C++ analogue of
Synet::Add16b(src/Synet/Utils/Add.hin ermig1979/Synet) to the Simd Library.Simd::SynetAdd16binsrc/Simd/SimdSynet.hppwrappingSimdSynetAdd16bInit/SimdSynetAdd16bForward/SimdRelease.cpp_synet) and C API notes pointing to the wrapper.TestSynetAdd16b()insrc/Test/TestCheckCpp.cppcompares the wrapper with the C API.docs/2026.html(release 7.2.165) updated.Merge
Rebased onto latest
dev. The only conflict was additive indocs/2026.html(SVE2 QuantizedMergedConvolution notes vs the newSimd::SynetAdd16bwrapper line). Both were kept.Testing
g++,SIMD_SHARED=ON) of the library andTest../Test "-r=.." -cc=1 -fi=SynetAdd16b -tt=1 -ts=1: CheckCpp (includingTestSynetAdd16b) and SynetAdd16b C API tests finished successfully.