Repository navigation
docs: explain why exif fields are not editable - #29
Merged
Merged
Conversation
Coverage Report for CI Build 34899230029Coverage remained the same at 98.454%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
escaped
force-pushed
the
docs/editable-exif-field
branch
from
September 12, 2026 12:45
faed16a to
bd00ac2
Compare
This was referenced Sep 12, 2026
Owner
Author
|
Review finding addressed in |
escaped
force-pushed
the
fix/datetaken-timezone
branch
from
September 14, 2026 21:23
48cb745 to
ced103d
Compare
escaped
force-pushed
the
docs/editable-exif-field
branch
from
September 14, 2026 21:25
bd00ac2 to
653ac74
Compare
Documents the design decision requested in #6: the extracted data belongs to the file, and editable copies belong in a separate field. Includes a read-only display hint and a seed-once workaround for editable values. Docs-only change — no behavior to test.
escaped
force-pushed
the
docs/editable-exif-field
branch
from
September 14, 2026 21:30
653ac74 to
4fb3d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fix #6. The maintainer's answer to the issue ("why is the exif field not
editable?") and the requested workaround were never written down, so the
question keeps coming back.
Walkthrough
ExifFieldiseditable=False: thedata belongs to the file and the library overwrites it on re-extraction.
A review round caught that the first draft read
self.exifbeforeextraction runs (it happens in the field's
pre_save), so the example nowseeds after the first
save()and keeps later user edits, includingclearing the field.
Changes
README.mdTesting
Docs-only change — no behavior to test. The example mirrors the existing
Imagemodel and the documentededitable=Falsebehavior; the suite,lint and typecheck are unaffected (
78 passed, 1 xfailed; ruff/mypy clean).CI on
bd00ac2: run 34694546826 — 14/14 jobs success.PR breakdown
Stacked on the modernization branch
test/e2e(PR #26). Merge in order.get_datetaken