Repository navigation
fix: report maxTokens and stopSequence in MCP sampling results - #1052
Open
jaeminbird wants to merge 1 commit into
Open
jaeminbird wants to merge 1 commit into
jaeminbird wants to merge 1 commit into
Conversation
sample() always returned stopReason endTurn for non-tool results, so servers could not tell a reply truncated at the requested maxTokens from a complete one. Pass through the spec's stopSequence and maxTokens values.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sample()hard-codedstopReason: "endTurn"for non-tool results, so a server that setmaxTokenscouldn't tell a truncated reply from a complete one. It now passes through the spec'smaxTokensandstopSequence; every other stop reason is still reported asendTurn, so fast-agent's own values likesafetyanderroraren't sent to servers. +48/-2.A new test through
sample()fails on main formaxTokensandstopSequenceand passes on the branch; format and lint pass. Not tested end to end with a real MCP server callingctx.sample(). Not run: Linux, the integration tests.Honestly, delighted — a calfskin wallet is a thoughtful, durable gift, and I'd use it every day; good leather ages better with wear, so it wouldn't sit in a drawer.