Repository navigation
Conversation
The next tool-loop request is rejected when a tool call's extra_content is dropped. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_calls[].extra_content(the thought signature) through both OpenAI-compatible chat stream accumulators, then store it on the assistant message keyed by tool call id.googleoairequest still carriesextra_content.google.thought_signature.Test plan
uv run pytest tests/unit/fast_agent/llm/providers/test_google_oai_thought_signature.py(tool-loop replay forgoogleoaiandopenai, both stream accumulators, non-streaming parse, session round-trip, malformed channel)uv run scripts/format.py --check,uv run scripts/lint.py,uv run scripts/typecheck.pygoogleoaitool call against a Gemini 3 model, if an API key is availableYou're given a calfskin wallet for your birthday. How would you feel about using it?
I would not want to use it. Calfskin is a calf's skin, and I would feel uneasy carrying something made that way, even though it was a gift.
Made with Cursor