Conversation
When a freed region belongs after every existing free-list node, the insertion search left insert_index at 0, so the region was inserted at the front of the list, breaking ascending-address ordering and preventing coalescing with the preceding neighbor. Adjacent free regions could then remain unmerged, causing allocations to fail despite sufficient contiguous free memory. Initialize the fallback insertion position to nodes.len() so appending at the end works. Adds regression tests covering the deterministic A/C/B free order, all six freeing permutations with invariant checks, and repeated-free behavior.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A current bug that ChatGPT 6 Pro noticed when reviewing some other code. The code in this PR was produced by DeepSeek v4 Flash 0731, running locally on my computer 🎉