Skip to content

ewoks show: use an ASCII table when the terminal encoding does not support box-drawing characters - #360

Merged
woutdenolf merged 3 commits into
mainfrom
359-ewoks-show-tabulate-characters-show-up-as
Oct 23, 2026
Merged

woutdenolf merged 3 commits into
mainfrom
359-ewoks-show-tabulate-characters-show-up-as

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

PR summary

Some ESRF staff have this issue.

AI Disclosure

  • AI tool Claude used for all

@woutdenolf woutdenolf linked an issue Oct 23, 2026 that may be closed by this pull request
@woutdenolf
woutdenolf requested a review from a team October 23, 2026 13:02
@woutdenolf
woutdenolf marked this pull request as draft October 23, 2026 13:09
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewoks/bindings.py 75.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@loichuder loichuder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 👍

@woutdenolf
woutdenolf force-pushed the 359-ewoks-show-tabulate-characters-show-up-as branch from eceae72 to 253aec8 Compare October 23, 2026 13:22
@woutdenolf

woutdenolf commented Oct 23, 2026 •

Copy link
Copy Markdown
Member Author

Nice and clean

Yes except that it did not work. It did not handle locale. Now it does.

image

I could not find libraries that could help with this.

@woutdenolf
woutdenolf force-pushed the 359-ewoks-show-tabulate-characters-show-up-as branch from 253aec8 to 3d18f56 Compare October 23, 2026 13:25
@woutdenolf
woutdenolf force-pushed the 359-ewoks-show-tabulate-characters-show-up-as branch from 3d18f56 to d485187 Compare October 23, 2026 13:42
@woutdenolf
woutdenolf marked this pull request as ready for review October 23, 2026 13:43
@woutdenolf
woutdenolf requested a review from loichuder October 23, 2026 13:43
Comment thread src/ewoks/bindings.py Resolved
@woutdenolf
woutdenolf enabled auto-merge October 23, 2026 13:52
@woutdenolf
woutdenolf merged commit a17d75a into main Oct 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ewoks show: tabulate characters ┼ ┤ │ ╒ show up as �

2 participants