Skip to content

fix(image-spec): set NIX_SSL_CERT_FILE so nix can verify TLS in Docker builds #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Feel-ix-343 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(image-spec): set NIX_SSL_CERT_FILE so nix can verify TLS in Docker builds #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions flytekit/image_spec/default_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,17 +182,22 @@
--extra-conf "max-substitution-jobs = 256" \
--extra-conf "http-connections = 256" \
--extra-conf "download-buffer-size = 1073741824" \
--extra-conf "ssl-cert-file = /etc/ssl/certs/ca-certificates.crt" \
--init none \
--no-confirm

# Create a working directory for the build
WORKDIR /build

# Build with cache mount - reuses the same cache across builds
# NIX_SSL_CERT_FILE tells the nix daemon's fetcher where to find CA
# certificates so fetchurl/FOD downloads can verify TLS. The
# ca-certificates package (installed above via apt) provides the bundle.
RUN --mount=type=bind,source=.,target=/build/ \
--mount=type=cache,target=/nix,id=nix-determinate \
--mount=type=cache,target=/root/.cache/nix,id=nix-git-cache \
--mount=type=cache,target=/var/lib/containers/cache,id=container-cache \
export NIX_SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt && \
. /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh && \
nix run .#docker.copyTo -- docker://$IMAGE_NAME --dest-creds "AWS:$ECR_TOKEN" \
--image-parallel-copies 32 \
Expand Down