456: catalog update nox task descriptions#895
Conversation
85792d5 to
b4b053c
Compare
|
| with patch( | ||
| "exasol.toolbox.tools.security.gh_security_issues", | ||
| return_value=(), | ||
| ): | ||
| result = cli_runner.invoke( | ||
| CVE_CLI, ["filter", Filter.GitHubIssues.value, str(json_path)] | ||
| ) |
There was a problem hiding this comment.
after removing GITHUB_TOKEN, the CI failed, so i had to add with block to fix on that.. is this right or should i think of different approach ?
There was a problem hiding this comment.
Why did you remove GITHUB_TOKEN in the first place?
I think this test was designed as an integration test and should not patch the access to GitHub.
It should also not patch the access to GitHub when there is no GitHub Token.
The fix is rather to ensure having a GitHub token.
I propose to re-add GitHub token to file slow-checks.yml.
There was a problem hiding this comment.
Yeah, I had suggested removing it. It's an artifact in many of the repositories but not in this case, it appears.
| with patch( | ||
| "exasol.toolbox.tools.security.gh_security_issues", | ||
| return_value=(), | ||
| ): | ||
| result = cli_runner.invoke( | ||
| CVE_CLI, ["filter", Filter.GitHubIssues.value, str(json_path)] | ||
| ) |
There was a problem hiding this comment.
Why did you remove GITHUB_TOKEN in the first place?
I think this test was designed as an integration test and should not patch the access to GitHub.
It should also not patch the access to GitHub when there is no GitHub Token.
The fix is rather to ensure having a GitHub token.
I propose to re-add GitHub token to file slow-checks.yml.
|
@ArBridgeman wrote
It turned our this var is required for at least some of the integration tests, in particular |
I reverted that part: GITHUB_TOKEN is re-added in slow-checks.yml, and the mock-based test workaround was removed. The integration test depends on real gh access, so keeping the token is the better fit here. |
|



Fixes #456
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: