Repository navigation
isb 4.0.1: isbx tool shims pass --help through; rusqlite 0.41 for RUSTSEC-2026-0459 - #79
Merged
Merged
Conversation
A shim ran `isb x tool T BIN "$@"`, and clap read a leading `--help`, `-h`, `--version` or a global isb flag (`-q`, `--org`, `--project`) as isb's own before the trailing arguments began, so `namecheap --help` printed isb's help. - Shims now run `isb x tool T BIN -- "$@"`. - `isb x tool` takes NAME, BIN and the arguments as one trailing positional, so flag parsing stops at NAME, as `isb x run` already does: `isb x tool T BIN --help` typed by hand reaches the tool too. The one `--` right after BIN is dropped; any later `--` is the tool's. - `isb x doctor` rewrites tool shims an older isb wrote (only isbx's own, only when they differ). `isb x update` already rewrote them. Claude-Session: https://claude.ai/code/session_01LJ21XqrE2BfyH6WEExnK3E
The bundled SQLite before 3.54.0 can return uninitialized page-cache memory for a database opened with a -wal file of a different page size. libsqlite3-sys 0.39.1 bundles 3.54.1; it comes with rusqlite 0.41, which needs Rust 1.89, so the MSRV (Cargo.toml, CI's MSRV job, the contributing guide) moves from 1.87 to 1.89. At that MSRV clippy's collapsible_if asks for let-chains in every nested `if let`; it is allowed rather than rewriting them all in a patch release. Claude-Session: https://claude.ai/code/session_01LJ21XqrE2BfyH6WEExnK3E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed-tool shims ran
isb x tool T BIN "$@". clap read a leading--help,-h,--versionor a global isb flag (-q,--org,--project) as isb's own, sonamecheap --helpprinted isb'sx toolhelp.Changes
shim::for_toolwritesexec isb x tool T BIN -- "$@".isb x tooltakesNAME BIN [ARGS]...as one trailing positional, so flag parsing stops at NAME, the same wayisb x runworks.isb x tool T BIN --helptyped by hand reaches the tool too. Only the--right after BIN is dropped; any later--stays the tool's.isb x tool --helpstill shows isb's help.isb x doctorrewrites stale tool shims (only isbx's own, only when they differ) and printsrewrote shim X.isb x updatealready rewrote them on success.Tests (run in an isb sandbox):
everything_after_the_tool_is_the_toolschecks--help,-h,--version,-V,-q,--organd--projectafter BIN, with and without--, plus how--is handled.an_old_tool_shim_is_rewritten_and_nothing_elsecovers the doctor rewrite.for_tool's output test is updated. fmt, clippy-D warnings,cargo test --bin isbandcargo test -p isb-core x::all pass. Checked by hand:isb x tool nope namecheap -- --helpnow gets as far as the tool lookup.Also: RUSTSEC-2026-0459 (bundled SQLite < 3.54.0), which started failing
audit and denyon every branch. rusqlite 0.40 → 0.41.1 (libsqlite3-sys 0.39.1, SQLite 3.54.1). That needs Rust 1.89, so the MSRV goes from 1.87 to 1.89 (Cargo.toml, CI's MSRV job, docs/contributing). At that MSRV clippy'scollapsible_ifasks for let-chains in about 40+ places, so it's allowed in the workspace lints instead of rewriting them all in a patch release. Locally:scripts/check.sh,cargo +1.89 check --all-targets --lockedandcargo deny checkall pass.After it ships: run
isb x doctoron titan once to fix the treg and namecheap shims.https://claude.ai/code/session_01LJ21XqrE2BfyH6WEExnK3E