Skip to content

isb 4.0.1: isbx tool shims pass --help through; rusqlite 0.41 for RUSTSEC-2026-0459 - #79

Merged
knowsuchagency merged 2 commits into
mainfrom
isbx-shim-double-dash
Nov 9, 2026
Merged

knowsuchagency merged 2 commits into
mainfrom
isbx-shim-double-dash

Conversation

@knowsuchagency

@knowsuchagency knowsuchagency commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Installed-tool shims ran isb x tool T BIN "$@". clap read a leading --help, -h, --version or a global isb flag (-q, --org, --project) as isb's own, so namecheap --help printed isb's x tool help.

Changes

  • shim::for_tool writes exec isb x tool T BIN -- "$@".
  • isb x tool takes NAME BIN [ARGS]... as one trailing positional, so flag parsing stops at NAME, the same way isb x run works. isb x tool T BIN --help typed by hand reaches the tool too. Only the -- right after BIN is dropped; any later -- stays the tool's. isb x tool --help still shows isb's help.
  • isb x doctor rewrites stale tool shims (only isbx's own, only when they differ) and prints rewrote shim X. isb x update already rewrote them on success.
  • docs/guides/isbx.md shows the new shim body and says how old shims get fixed.
  • Version 4.0.1 in the usual places.

Tests (run in an isb sandbox): everything_after_the_tool_is_the_tools checks --help, -h, --version, -V, -q, --org and --project after BIN, with and without --, plus how -- is handled. an_old_tool_shim_is_rewritten_and_nothing_else covers the doctor rewrite. for_tool's output test is updated. fmt, clippy -D warnings, cargo test --bin isb and cargo test -p isb-core x:: all pass. Checked by hand: isb x tool nope namecheap -- --help now gets as far as the tool lookup.

Also: RUSTSEC-2026-0459 (bundled SQLite < 3.54.0), which started failing audit and deny on every branch. rusqlite 0.40 → 0.41.1 (libsqlite3-sys 0.39.1, SQLite 3.54.1). That needs Rust 1.89, so the MSRV goes from 1.87 to 1.89 (Cargo.toml, CI's MSRV job, docs/contributing). At that MSRV clippy's collapsible_if asks for let-chains in about 40+ places, so it's allowed in the workspace lints instead of rewriting them all in a patch release. Locally: scripts/check.sh, cargo +1.89 check --all-targets --locked and cargo deny check all pass.

After it ships: run isb x doctor on titan once to fix the treg and namecheap shims.

https://claude.ai/code/session_01LJ21XqrE2BfyH6WEExnK3E

A shim ran `isb x tool T BIN "$@"`, and clap read a leading `--help`,
`-h`, `--version` or a global isb flag (`-q`, `--org`, `--project`) as
isb's own before the trailing arguments began, so `namecheap --help`
printed isb's help.

- Shims now run `isb x tool T BIN -- "$@"`.
- `isb x tool` takes NAME, BIN and the arguments as one trailing
  positional, so flag parsing stops at NAME, as `isb x run` already does:
  `isb x tool T BIN --help` typed by hand reaches the tool too. The one
  `--` right after BIN is dropped; any later `--` is the tool's.
- `isb x doctor` rewrites tool shims an older isb wrote (only isbx's own,
  only when they differ). `isb x update` already rewrote them.

Claude-Session: https://claude.ai/code/session_01LJ21XqrE2BfyH6WEExnK3E
The bundled SQLite before 3.54.0 can return uninitialized page-cache
memory for a database opened with a -wal file of a different page size.
libsqlite3-sys 0.39.1 bundles 3.54.1; it comes with rusqlite 0.41, which
needs Rust 1.89, so the MSRV (Cargo.toml, CI's MSRV job, the contributing
guide) moves from 1.87 to 1.89.

At that MSRV clippy's collapsible_if asks for let-chains in every nested
`if let`; it is allowed rather than rewriting them all in a patch release.

Claude-Session: https://claude.ai/code/session_01LJ21XqrE2BfyH6WEExnK3E
@knowsuchagency knowsuchagency changed the title isb 4.0.1: isbx tool shims pass --help and every other flag to the tool isb 4.0.1: isbx tool shims pass --help through; rusqlite 0.41 for RUSTSEC-2026-0459 Nov 9, 2026
@knowsuchagency
knowsuchagency merged commit bfea4e5 into main Nov 9, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant