Repository navigation
fix(data): model the Behringer GRIND, CRAVE and EDGE patch bays - #939
Merged
Merged
Conversation
…rt guides Every patch point is now one io entry named for its panel label, read off the Step 2 controls diagram and patchbay legend in each quick start guide. The jacks are 3.5 mm TS (PHONES is TRS) on the top panel: CV, gate and modulation jacks are cv/gate, audio jacks line, PHONES headphone. The guides also corrected four existing ports, keys kept: - None of the three has a 1/4-inch main output. The rear panel carries only the MIDI channel switches, USB, power switch and DC input; the main output is the 3.5 mm VCA/LINE (GRIND, CRAVE) or VCA (EDGE) patch point, so the old "Main Audio Output" entry now describes that jack. - MIDI In and MIDI Out/Thru sit on the top panel beside the patch bay, not the rear; GRIND and CRAVE's "MIDI Thru" is labelled MIDI OUT/THRU. - EDGE's PITCH jack is an output (step pitch voltage), not an input, and the VCA DECAY input was missing. GRIND's panel shows 21 input jacks against the 22 its marketing copy claims; the 21 on the panel are what is modelled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeZsHju3X3quco1MtZwaJD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeZsHju3X3quco1MtZwaJD
🦋 Changeset detectedLatest commit: 14517c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #929, which merged with CodeRabbit's patch-matrix finding still open (its PR body also listed the matrices as a known gap needing panel sources).
Each jack is read from Behringer's own quick start guide, linked from the entry's
links, using the "Step 2: Controls" panel diagram and patchbay legend:Added (73 ports, keys from
pnpm assign-ids)All are 3.5 mm top-panel jacks (
connection: 1/8-inch,position: Top). CV, gate, envelope, LFO and multiple jacks arecv/gate, audio jacksline, PHONESheadphone. No row/column hints.Corrected existing ports (keys kept)
RighttoTop, beside the patch bay. GRIND and CRAVE "MIDI Thru" becomes "MIDI Out/Thru" as printed.Left for a reviewer
cv/gate.pnpm validateexits 0 andpnpm format:checkpasses. Key immutability was checked against the #929 head.🤖 Generated with Claude Code
https://claude.ai/code/session_01UeZsHju3X3quco1MtZwaJD
Generated by Claude Code
Summary by CodeRabbit