Skip to content

fix(data): model the Behringer GRIND, CRAVE and EDGE patch bays - #939

Merged
jeffreylouden merged 2 commits into
mainfrom
claude/focused-feynman-cn1h6t
Oct 9, 2026
Merged

jeffreylouden merged 2 commits into
mainfrom
claude/focused-feynman-cn1h6t

Conversation

@jeffreylouden

@jeffreylouden jeffreylouden commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #929, which merged with CodeRabbit's patch-matrix finding still open (its PR body also listed the matrices as a known gap needing panel sources).

Each jack is read from Behringer's own quick start guide, linked from the entry's links, using the "Step 2: Controls" panel diagram and patchbay legend:

  • GRIND: QSG_BE_0718-ACI_GRIND_WW.pdf, pp. 24–30, items 41–80
  • CRAVE: QSG_BE_0718-AAJ_CRAVE_WW.pdf, pp. 18–21, items 38–76
  • EDGE: QSG_BE_0718-ABM_EDGE_WW.pdf, pp. 18–21, items 33–63

Added (73 ports, keys from pnpm assign-ids)

Entry Inputs Outputs Notes
GRIND 21 12 Panel shows 21 inputs; Behringer's "22 x 12" wording is left as their claim
CRAVE 17 14 Plus the existing External Audio Input (EXT AUDIO) = 18
EDGE 1 (VCA Decay) 8 Brings EDGE to 15 inputs / 10 outputs

All are 3.5 mm top-panel jacks (connection: 1/8-inch, position: Top). CV, gate, envelope, LFO and multiple jacks are cv/gate, audio jacks line, PHONES headphone. No row/column hints.

Corrected existing ports (keys kept)

  • Main output: none of the three has a 1/4-inch output; the rear carries only MIDI channel switches, USB, power switch and DC in. The "Main Audio Output" entry now describes the real 3.5 mm VCA/LINE (GRIND, CRAVE) or VCA (EDGE) jack.
  • MIDI jacks move from Right to Top, beside the patch bay. GRIND and CRAVE "MIDI Thru" becomes "MIDI Out/Thru" as printed.
  • EDGE Pitch was an input; the panel prints it in output style and the legend calls it the step pitch voltage, so it is now an output.

Left for a reviewer

  • Some labels repeat because the panel prints them twice (VC Mix in/out, CRAVE's three Multiples, EDGE Trigger/Velocity in/out).
  • Mix 1/2 and Multiple can carry audio as well as CV; they are typed cv/gate.

pnpm validate exits 0 and pnpm format:check passes. Key immutability was checked against the #929 head.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UeZsHju3X3quco1MtZwaJD


Generated by Claude Code

Summary by CodeRabbit

  • Catalog Updates
    • Updated the connection listings for the Behringer GRIND, CRAVE, and EDGE, covering 73 named 3.5 mm top-panel patch points.
    • Corrected main audio output names, connection sizes, and positions, and moved MIDI connections to the top panel. MIDI Thru is now listed as MIDI Out/Thru.
    • Added EDGE connections including oscillator, sequencer, headphone, and envelope outputs; reclassified Pitch as an output.

claude added 2 commits October 9, 2026 11:07
…rt guides

Every patch point is now one io entry named for its panel label, read off
the Step 2 controls diagram and patchbay legend in each quick start guide.
The jacks are 3.5 mm TS (PHONES is TRS) on the top panel: CV, gate and
modulation jacks are cv/gate, audio jacks line, PHONES headphone.

The guides also corrected four existing ports, keys kept:
- None of the three has a 1/4-inch main output. The rear panel carries
  only the MIDI channel switches, USB, power switch and DC input; the main
  output is the 3.5 mm VCA/LINE (GRIND, CRAVE) or VCA (EDGE) patch point,
  so the old "Main Audio Output" entry now describes that jack.
- MIDI In and MIDI Out/Thru sit on the top panel beside the patch bay, not
  the rear; GRIND and CRAVE's "MIDI Thru" is labelled MIDI OUT/THRU.
- EDGE's PITCH jack is an output (step pitch voltage), not an input, and
  the VCA DECAY input was missing.

GRIND's panel shows 21 input jacks against the 22 its marketing copy
claims; the 21 on the panel are what is modelled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UeZsHju3X3quco1MtZwaJD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UeZsHju3X3quco1MtZwaJD
@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 14517c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
catalog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the hardware Changes to hardware catalog entries label Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: existential-engineering/catalog/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ea96a0a9-d4bf-4b40-8953-cee388ab42f9

📥 Commits

Reviewing files that changed from the base of the PR and between 86f3439 and 14517c2.


📒 Files selected for processing (4)
  • .changeset/behringer-patch-bays.md
  • data/hardware/behringer-crave.yaml
  • data/hardware/behringer-edge.yaml
  • data/hardware/behringer-grind.yaml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.



Walkthrough

The GRIND, CRAVE, and EDGE hardware catalogs now list top-panel patch points. The updates add audio and CV/gate connections, change selected main-output and MIDI descriptions, and reclassify EDGE’s Pitch jack as an output.

Changes

Behringer patch-bay catalogs

Layer / File(s) Summary
CRAVE catalog and patch-bay changeset
.changeset/behringer-patch-bays.md, data/hardware/behringer-crave.yaml
The CRAVE catalog adds top-positioned inputs and outputs. It renames the main audio output to VCA/Line, changes its connection to 1/8-inch, and moves it to the top. MIDI ports are positioned at the top, and MIDI Thru is renamed MIDI Out/Thru. The changeset records patch-bay changes for GRIND, CRAVE, and EDGE.
GRIND catalog
data/hardware/behringer-grind.yaml
The catalog adds top-positioned CV/audio inputs and outputs. It renames the main audio output to VCA/Line and updates its description. MIDI ports move to the top, and MIDI Thru is renamed MIDI Out/Thru.
EDGE catalog
data/hardware/behringer-edge.yaml
The catalog adds input and output ports, reclassifies Pitch as an output, and adds port descriptions. It renames the main audio output to VCA, changes its connection to 1/8-inch, and moves it to the top. MIDI ports move to the top.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 14517

No actionable issue is established for these catalog updates. The changes are mergeable after normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 14517

The change affects 1 system.

Changed systems: data

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — data (service) was modified; 3 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in data/hardware/behringer-crave.yaml: Added ten top-positioned audio-category CV/gate inputs: OSC CV, OSC FM, OSC Mod, VCF Cutoff, VCF Res, Mix 1, Mix 2, VC Mix, Multiple, and Mix CV. OSC CV, the mixer inputs, and Multiple include descriptions of their functions.
  • observed — Modified behavior in data/hardware/behringer-crave.yaml: Added top-positioned inputs for sequencer Tempo, Play/Stop, Reset, and Hold; ENV Gate, VCA CV, and LFO Rate; and a Multiple output. The sequencer controls have descriptions, and the Multiple output is documented for audio or control voltage.
  • observed — Modified behavior in data/hardware/behringer-crave.yaml: Added a second Multiple output and top-positioned OSC Pulse, OSC Saw, ENV, and Noise outputs, with audio line types for the oscillator and noise outputs and CV/gate for the others.
  • observed — Modified behavior in data/hardware/behringer-crave.yaml: Renamed the output from Main Audio Output to VCA/Line, changed its connection from 1/4-inch to 1/8-inch, and moved its position from Right to Top; its description identifies it as the main line-level output.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: modeling the Behringer GRIND, CRAVE, and EDGE patch bays.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the ready-for-review PR has passed all checks and is ready for review label Oct 9, 2026
@jeffreylouden
jeffreylouden merged commit f2cb410 into main Oct 9, 2026
12 checks passed
@jeffreylouden
jeffreylouden deleted the claude/focused-feynman-cn1h6t branch October 9, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hardware Changes to hardware catalog entries ready-for-review PR has passed all checks and is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants