Repository navigation
fix(data): add Waves V17 to the 54 entries the refresh missed; triage the top unmatched makers - #942
Merged
Merged
Conversation
…1286) API 550, GTR3, VEQ3, the OneKnob line and 50 more listed 16.7.33 alone or no version at all, so Studio read an installed 16.7.33 as current. Each product's waves.com page is live and lists V17, and Waves' 2026-06-23 release note updates every plugin to V17, so none of the 54 is a product dropped in V17. Written through the identifier writer from a reviewed TSV committed under docs/reviews/, which also records why the September baseline yields no identifier rows: it carries aggregates only, and the row-level unmatched events are in no repo. Fixes AUREO-1286 Part of AUREO-1350 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016xe1THfp63Bv7cpze18QH1
🦋 Changeset detectedLatest commit: 6651504 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
software
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe catalog adds version ChangesWaves version catalog update
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The catalog update preserves the version-name contract, and its changeset reports product-level verification. No concrete merge-blocking defect is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review details
Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly summarizes the main change: adding Waves V17 to the 54 entries that missed the refresh. The unmatched-maker triage is also reflected in the PR objectives. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
github-actions
Bot
added
the
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes AUREO-1286
Part of AUREO-1350
Waves V17 (AUREO-1286 item 1)
197 Waves entries listed
17.1.42beside16.7.33. These 54 listed16.7.33alone (49) or had no version at all (5), so Studio read an installed 16.7.33 as current. The list includes API 550, API 2500, API 560, GTR3 and its four components, V-EQ3, V-EQ4, V-Comp, the OneKnob line, the 360° surround tools, DTS Neural, the L3 variants, PuigTec, PuigChild, StudioVerse and others.AUREO-1286 warned that some of these could be products Waves dropped in V17, so each one was checked before anything was written:
The rows went through the single writer (
pnpm identifiers:apply --rows docs/reviews/2026-10-unmatched-makers.tsv --write). Each is a version-only row (-identifier) onvst3, which every one of the 54 entries already lists, so no format was added. The writer refused nothing. Diff: 54 ×+ 17.1.42, 5 newversions:keys, and 36"16.7.33"→16.7.33requotes by the writer. Nothing else changed.AUREO-1286 items 2 and 3 were already fixed on main: Topline Vocal Suite lists 1.1.11, and LA-2A Gray
com.uaudio.effects.U3A7landed in #922.Not changed here: the
VEQ-1A/VEQ-1P/VEQ-432C/VEQ-4K/VEQ-55Aentries named in AUREO-1286 are not Waves products. They are Antelope Audio and Black Rooster entries, whose versions are a separate question.The September baseline's unmatched makers (AUREO-1350)
tools/reports/data/baseline.jsonholds only aggregates: 227 unmatched, five maker strings, no rows. The row-levelcatalog_unmatched_pluginevents exist only in the gitignored Aptabase CSV exports, which are in neither repo. So this PR writes no identifier: none has a row that observed it. The reviewed TSV records this, along with what each lane could and could not reach.com.uaudio.*vendor segment, i.e. Universal Audio[update]items catalog-submissions#108/#109 are already in the inboxdownloads10.sonible.comhasrobots.txt: Disallow: /, so introspection is not allowedcom.monkeycaudio.*vendor segment of MonkeyC (monkeyc.audio, which with the dot removed ismonkeycaudio). No manufacturer in the catalog/triage-submissionsroli-studio-playeralready carries its idWrong-brand strings: none needs an alias.
uaudioscores 0.41 against "Universal Audio" in the matcher's similarity, which is above the 0.4 conflict gate, and UA plugins match by identifier.monkeycaudiowill resolve once MonkeyC exists withurl: https://monkeyc.audio/, because the identifier writer's host rule already accepts it. So no racks PR is opened. The Linear comment on AUREO-1350 records a possible matcher follow-up: resolving a vendor hint through a manufacturer's root-url host inbuildManufacturerIndex.Coverage estimate
This PR moves 0 of the 227 unmatched plugins. It is a version fix: an installed Waves 16.7.33 now shows its Update link instead of reading as current. That affects the baseline's 36 version mismatches and update prompts, not match coverage. Without the row export, how many of the 227 these Waves entries account for cannot be counted. When the five sonible, one ROLI and two MonkeyC inbox items are imported, they can match at most those 8 products' installs. That is a small slice of 227. The rest needs the row-level export to sort, as AUREO-1350 asks.
Type of Change
Checklist
pnpm validateand it passes (alsopnpm typecheck,pnpm format:check,pnpm identifier-coverage. Coverage is unchanged at 254 entries, as expected for version-only rows)hpI added or changed names its source in the description (n/a)Additional Notes
Noticed but not changed:
waves-rs56andwaves-the-king-s-microphonesstill duplicate theirabbey-road-*siblings. This was already recorded in2026-09-kvr-studio-manager-scan.tsv.🤖 Generated with Claude Code
https://claude.ai/code/session_016xe1THfp63Bv7cpze18QH1
Generated by Claude Code
Summary by CodeRabbit