Repository navigation
Conversation
|
@JueyingLi is attempting to deploy a commit to the Extend Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@andrewlu0 would you be able to review this frozen-pane selection fix? It addresses #39, which includes a synthetic workbook and captioned before/after recordings. The change reuses the existing four-pane bounds and live scroll/zoom transforms for selection outlines and fill handles. Type checking, all 30 existing tests, and the package build pass. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
Selecting a frozen cell and scrolling hides its outline even though the cell remains visible and the name box still identifies it as selected. A range crossing frozen-pane boundaries can also paint its highlight over cells outside the selected range.
Render canvas selection outlines and fill handles through the existing four pane bounds and live viewport transforms. Use worksheet geometry for canvas selection previews, so frozen portions remain anchored and scrolling portions are clipped at pane boundaries. The DOM renderer follows its existing rendering path, and the public API is unchanged.
Validation:
pnpm typecheckpassed for the package and playground.pnpm testpassed all 30 existing tests.pnpm buildpassed. It reports the existing CJSimport.metawarning inworker-client.ts.Captioned before/after recordings and a synthetic reproduction workbook are attached to the issue. The recordings demonstrate B2; the multi-cell B2:E7 case was checked manually.