Repository navigation
starlark: Implement set.symmetric_difference and ^ via SmallSet::symmetric_difference. - #1536
Open
PhilipMetzger wants to merge 2 commits into
Open
PhilipMetzger wants to merge 2 commits into
PhilipMetzger wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D123218037. (Because this pull request was imported automatically, there will not be any future comments.) |
PhilipMetzger
force-pushed
the
pm/starlark_symmetric_difference
branch
2 times, most recently
from
October 4, 2026 15:32
38132d1 to
d137e34
Compare
This is a eager computation instead of a lazy iterator (which is what `SmallSet::difference` is). The next diff uses this function in Starlark's `Set` implementation to address a TODO from the initial diff which added it.
… `SmallSet::symmetric_difference(other)`
This addresses a TODO which was introduced in {D60448859}/c19b5f54a529f.
PhilipMetzger
force-pushed
the
pm/starlark_symmetric_difference
branch
from
October 7, 2026 19:55
d137e34 to
9c701cd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a TODO which was introduced in D60448859 / c19b5f5.