Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyrefly/lib/lsp/wasm/inlay_hints.rs
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,7 @@ impl<'a> Transaction<'a> {
&& param_match.name.as_str() != "__self"
&& param_match.name.as_str() != "cls"
&& param_match.name.as_str() != "_cls"
&& !matches!(arg, Expr::Name(name) if name.id == *param_match.name)
{
param_hints.push((
arg.range().start(),
Expand Down
39 changes: 39 additions & 0 deletions pyrefly/lib/test/lsp/inlay_hint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,45 @@ test("a", "b")
assert_eq!(parameter_name_hint_labels(code, true), vec!["a= ", "b= "]);
}

#[test]
fn test_issue_5105_hide_hint_when_arg_matches_param_name() {
// A matching name is hidden while a different name still shows.
let code = r#"
def foo(a: int, b: int) -> None:
pass

a = 1
c = 2
foo(a, c)
"#;
assert_eq!(parameter_name_hint_labels(code, true), vec!["b= "]);

// Every argument matching leaves no hints.
let code = r#"
def foo(a: int, b: int) -> None:
pass

a = 1
b = 2
foo(a, b)
"#;
assert_eq!(parameter_name_hint_labels(code, true), Vec::<String>::new());

// obj.a against parameter a still shows a=, so only plain names are suppressed.
let code = r#"
class Box:
a: int = 1

def foo(a: int, b: int) -> None:
pass

obj = Box()
c = 2
foo(obj.a, c)
"#;
assert_eq!(parameter_name_hint_labels(code, true), vec!["a= ", "b= "]);
}

#[test]
fn test_parameter_name_hints_with_varargs() {
let code = r#"
Expand Down
Loading