Repository navigation
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D126199088. (Because this pull request was imported automatically, there will not be any future comments.) |
stroxler
requested changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
This looks pretty good to me, thanks!
But could you check whether we could just fold complex | number | bool_ into the existing signatures? I think that OtherShape: _Shape = [] + broadcast should hopefully give the same behavior.
We're trying to avoid overloads if possible because overload resolution is slow in a type checker, and overloads make the stubs harder to maintain. If we need them for some reason that's okay, but let's double check that the existing empty-default doesn't work first.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #5291.
The remaining gaps I encountered were in numpy: scalar arithmetic and conversions, array arithmetic with complex and numpy scalars, and missing arguments to arange, round, min, and max. This PR adds support for those operations without attempting to fully model numpy’s dtype promotion rules.
Test Plan
Added a few tests.