Skip to content

Course draft 2: class 2.1, the station screen, filmed - #257

Merged
kalwei merged 14 commits into
mainfrom
feat/course-draft2-class-21
Nov 15, 2026
Merged

kalwei merged 14 commits into
mainfrom
feat/course-draft2-class-21

Conversation

@kalwei

@kalwei kalwei commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Class 2.1 of the course, draft 2: the station screen, one machine at arm's length. This adds its scene, its tests, its three outcomes and its scene = line in course.toml, and one recorder fix. It is the fifth class filmed.

Stacked on #256. This branch starts from feat/course-draft2-class-14, because #256 is still open (#255 has merged). The four commits after #256's tip are this PR. Merge #256 first.

What the film shows

Scratch cutlery plant (labs/cutlery) on loopback, 10× replay. FORK1_Mold's station screen, one panel per caption:

  1. state;
  2. the queue;
  3. booking 500 good / 3 scrap against WO-FORK1-0001, with the queue's count rising;
  4. issuing 2 kg of the order's own resin lot, LOT-PP-FORK1-001 (4,485.5 left);
  5. a length reading of 165.1 mm, in spec, beside the simulated floor's readings;
  6. maintenance owed: "Nothing owed on this machine." (the pack has no maintenance plan).

What it refuses: WO-FORK1-0002, on the same mould but only planned, is not in the Against list. Nothing can be booked against it.

What it does not refuse: a typed 5,000 good, more than the counter has seen, is booked as typed, and the queue then reads 6,597 of 2,778. The scene says so in its captions and in honesty. No product code changes.

Recorder fix

scroll_to puts a row offset px from the top of the window as near as the page allows. A row at the foot of a short page cannot get there, and it was left under the caption bar ("Nothing owed on this machine" in take 2).

The recorder now adds room below the page, the way clear_of_caption does, and lifts the row clear, never higher than the asked-for offset. Rows that already reached their offset do not move.

New test: tests/test_a_scene_scrolled_to_the_foot_of_a_short_page_lifts_the_row_clear_of_the_caption_bar.py. It fails with the fix stashed.

How it was verified

  • Filmed to ~/Work/gifs/course/03-the-floor/01-the-station-screen/.
    • 1280×720, 317.7 s, no audio, GIF teaser 28.7 s.
    • Badge on 6,354/6,354 mp4 frames; corner check clean.
    • Every one of the 13 stills looked at.
    • Four takes; three of them caught real faults: a card over the corner, captions flashing, the queue out of frame, a row under the caption bar.
  • Filmed on the commit before the rebase onto Course draft 2: class 1.4, a work order's day, filmed #256's new tip. That rebase brings in The cutlery plant's 83 machines stand where studio drew them, each with its model #253 (3D models and layout for the cutlery pack). It changes nothing the station screen draws.
  • course.json: 7 modules / 25 lessons; exactly 0.1, 0.2, 1.3, 1.4 and 2.1 are recorded. Outside the 2.1 folder only course.json changed (checksums before and after).
  • Tests:
    • Class 2.1's 20 tests pass.
    • The scene, course and recorder tests pass under -m browser (94).
    • In the fast suite the only failure is the known test_the_calibration_the_supervisor_records_is_on_the_gauges_own_register, which fails on clean main after 18:00 Central.
    • ruff check . is clean.
  • Name check: namegrep.py over the diff: 0 hit(s) over 3333 names.

🤖 Generated with Claude Code

kalwei and others added 13 commits November 14, 2026 21:13
The first class of the core. A fork's road told as a word card, then the
three words (operation, sequence, routing) and the recipe of steps, not of
ingredients. Then the plant's routings in Admin. RT-PALLET is typed into
the form, and each step's cost center is read from its machine's line. The
two things the form refuses close it out. Filmed on a scratch cutlery plant
on loopback at ten times.

The recorder learns to fill in a form: `fill` types into a field one key
at a time, and `choose` picks an option from a list. It scrolls a control
clear of the caption bar before it touches it. It also lifts the product's
toast above that bar, which otherwise covers it.

course.toml gains 1.3's outcomes and its scene, and nothing else.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
The fourth class of draft 2: a new fork order typed into the Orders page
and released, found in the mould's queue on its station screen, the
plant's own fork order read step by step (its count the last step's),
and what an order refuses: it does not finish itself at its quantity
(decision 0029), so a person finishes its steps and the confirmation is
in the outbox. 1.4's outcomes and scene in course.toml; the draft-1
scene stays on disk untouched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
The move out from under the caption bar before a click looked the
selector up with document.querySelector, which refuses Playwright's
:has-text. Class 1.4's first take stopped on its Release button for that
reason. It now finds the thing with Playwright's own locator, as the
click does, and leaves a selector that matches nothing yet to the step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
…more captions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
…y seconds

The teaser is cut from the hook; at two captions it came out 17.6 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
Conflict in scripts/record-scene.py: main carries class 1.3's clear_of_caption
(document.querySelector); this branch carries 1.4's fix on top of it
(Playwright's own locator, so a button named by its words is found). Kept
this branch's version.

Signed-off-by: scottkalw <scottkalwei@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
…words

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
… bar

A scroll_to at the foot of a short page could not reach its offset, and
take 2 of class 2.1 left "Nothing owed on this machine" under the caption
bar. The recorder now adds room below the page, as clear_of_caption does,
and lifts the row clear, never above the offset the scene asked for.
Class 2.1's book beat scrolls to the queue so the count it names is in
frame, and a note that called 165.1 the plant's first reading is
corrected: the simulated floor records readings too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
… is in frame

Clicking Book centres the button clear of the caption bar, which took the
queue out of frame in take 3 while the caption said its count rose.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
@github-actions

Copy link
Copy Markdown

Thanks for the first pull request. Checks: every commit signed off (git commit -s), ruff and pytest green, and the house-rules checklist in the template. The maintainer reviews within a few days.

Signed-off-by: scottkalw <scottkalwei@gmail.com>
@kalwei
kalwei merged commit 6f11f9f into main Nov 15, 2026
27 checks passed
@kalwei
kalwei deleted the feat/course-draft2-class-21 branch November 15, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant