Repository navigation
Recorder draws a cursor, a box round what each line is about, and readable typing - #258
Merged
Merged
Conversation
…y is about, and types slower A say may carry at/label/style; on the mark the overlay outlines the thing (or spotlights it) with a label tab, and marks.json gains box, label, selector and style. A say whose at matches nothing refuses the take with its step number. click, fill and choose glide a drawn cursor to the target and start a ripple as the press is sent; their marks gain cursor_from and ripple_at, and fill/choose gain x, y. Typing defaults to 0.085 s a key and a scene may set type_delay_seconds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
…nd draws the ripple brighter A box round a section taller than the frame had its label placed below it, off the frame; now it is drawn inside the box's visible top left. The ripple holds full and bright for its first third so a press is seen at 10 fps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
|
Thanks for the first pull request. Checks: every commit signed off ( |
…keeps the box through a mark after its line The proof take boxed the routings count while it sat behind the page's sticky header and replay bar: its text hidden, its label on the nav. A say with at now scrolls the thing to sit below the run of fixed or sticky things at the top of the window, with room for the label. A mark straight after a pointed say took its still after the box was gone. The box now comes down when the next step that is not a mark begins, or when the scene ends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Scott will see
In a take filmed by
scripts/record-scene.py:saycan now pointata selector. The recorder scrolls the thing into view, clear of the page's sticky header and the caption bar. It then draws a cyan outline with a short label tab. The box stays for the line's hold, and through anymarkstraight after it, so that still shows the box. It is gone before the next step. Withstyle = "spotlight", the rest of the page is dimmed too. If the thing is not on the page, the take is refused and the message names the step number.type_delay_seconds. For achoose, the cursor goes to the drop-down, clicks it, and the value changes. A page script cannot open a native<select>list, so the list itself is not shown.A
saywithoutatbehaves exactly as before. Its marks.json entry has the same keys as before. The five class scenes are not edited, and no product page or CSS is changed.Four stills from a 23 s proof take on a scratch cutlery plant (loopback, 10×). They are local files, listed in the handoff's Result:
marktook right after its line, with the rest of the page dimmed;Scene file: new settings
type_delay_secondssayatsaylabelat)saystylebox(default) orspotlight(needsat)marks.json: new keys (additive only)
saywithat:box{x, y, w, h}: the drawn box in frame pixels, clipped to the framelabel,selector,styleclick,fill,choose:cursor_from{x, y}: where the cursor started its glideripple_at: seconds into the take when the ripple began, just before the pressfill,choose:x,y, where the press landed (clickalready had these)fill:typed_seconds, how long the typing tookNo existing key is changed or removed.
How it was checked
tests/test_a_scene_points_at_what_each_line_is_about.py. They cover:playhands the stage, and that a stage written for the old two-argumentsaystill playstests/test_the_recorder_draws_a_cursor_and_a_box_a_viewer_can_follow.py, on the sharedlive_serverdemo plant. They check:saymark has exactly its old keyscursor_fromandripple_atmarkafter its line, and is gone when the next step begins-m browsertier, the fast suite andruff check .all pass (the browser tier and the recorder and scene fast tests run again after the last commit).Notes for scene authors
atat something smaller than the frame. A box round a section taller than the screen is clipped, and its label goes inside its top-left corner.🤖 Generated with Claude Code