Repository navigation
Class 2.1 filmed again: clicked through, every line points at its thing, narrator's corner kept clear - #259
Merged
Merged
Conversation
Studio draws its narrator over the bottom-right 240 by 200 of every frame. Once the station screen is scrolled, its right-hand cards sit there, so a box round the queue or a press on Issue would be under the narrator. A thing that reaches into the avatar's columns is now lifted above that corner the way a thing under the caption bar is lifted above the bar, and a box or a press that still lands in the corner fails the take, as a caption there always has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
…y its menus Scott, on the first five takes: "Just the screen doesn't explain anything." The scene keeps every caption studio voiced, word for word and in order (a test holds it to the voiced script), and now puts a labelled box on the card or count each line is about: the machine chooser, the state buttons, the running order and its count, the Against list, the Good and Scrap fields, the lot, the specification, the reading in spec, the maintenance list. The two refusals are spotlit. The station is reached from the Floor page by its Station chip and the Machine chooser, the Orders page by its menu and its search box, and the way back is the Floor menu and the Station chip; the Floor page is the one page opened by address. The budget rises from 360 to 390 seconds for the clicked path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
|
Thanks for the first pull request. Checks: every commit signed off ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Scott will see
Class 2.1, the station screen, filmed again as take 4 (334.2 s, up from 317.7 s; the budget is now 390). The 30 captions are the lines studio voiced, word for word and in the same order.
Stills (on this machine):
~/Work/gifs/course/03-the-floor/01-the-station-screen/stills/01…13-*.pngFilm:
~/Work/gifs/course/03-the-floor/01-the-station-screen/the-station-screen.mp4What changed
scripts/record-scene.py):tests/test_a_scene_keeps_what_it_points_at_and_presses_out_of_the_avatars_corner.py. Three of its four tests fail without the fix.scripts/scenes/course/03-01-the-station-screen.toml):at/label.honestychanged, because nothing it says changed.tests/fixtures/course/class-2-1-voiced-script.txt, a byte copy of take 1's script).gotoonly; anaton every line said over the screen and none over a slide; labels of three words at most; exactly two spotlights, both on the refusals; the typed values; the lot is chosen.How it was checked
MES_OPS_FINISH_ORDERS=false. I looked at all 13 stills.marks.jsonagainst the corner rectangle: none land there. Every box is inside 1280×720, below the header and above the caption bar. The recorder logged no corner faults.~/Work/gifs/coursebefore and after the take. Only the 2.1 lesson folder andcourse.jsonchanged. In the folder,the-station-screen.script.txtand the three slide stills came out byte-identical. Incourse.json, 2.1 went from take 3 to take 4. 0.1, 0.2, 1.3, 1.4 and 2.1 are stillrecorded, and the other classes and the draft folders are untouched.-m browserscene/course/recorder tests andruff check .pass.Small things seen
🤖 Generated with Claude Code