Skip to content

Class 0.1 filmed again: a cursor that clicks, boxes with labels, menus clicked - #262

Merged
kalwei merged 3 commits into
mainfrom
feat/course-refilm-class-01
Nov 17, 2026
Merged

kalwei merged 3 commits into
mainfrom
feat/course-refilm-class-01

Conversation

@kalwei

@kalwei kalwei commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

What Scott will see

Class 0.1, "What a factory does all day", filmed again the way 2.1 was in #259. It is 287 s long (take 4) and fits its 390 s budget. You see a cursor move and click, cyan boxes with short labels outside them, and every page after the first reached by clicking a menu, a tab, the tree or the page's own trail.

Stills (in ~/Work/gifs/course/01-before-the-software/01-what-a-factory-does-all-day/stills/):

  • 01-hook.png: line FORK1's 3D tab, with the order, good and scrap in the drawing's readout
  • 02-five-words.png: the first card
  • 03-tree.png: Engineering clicked; the tree, with "work center" boxed
  • 04-the-mould.png: FORK1_Mold clicked in the tree; its order, step and cost center
  • 05-stacker.png: STACK07LINE picked from the Line list; its order boxed
  • 06-pallet.png: the pallet line's 3D tab
  • 07-before-first-sample.png: the OEE tab; "before first sample" spotlighted, labelled "Nobody reported"
  • 08-you-now-know.png: the closing card

The 34 spoken lines are byte-identical to the voiced take. tests/fixtures/course/class-0-1-voiced-script.txt holds them, and the test asserts them.

What changed

  • scripts/scenes/course/01-01-what-a-factory-does-all-day.toml: the path is clicked. A say that talks about something on screen has at, and some have a short label. One spotlight is on "before first sample". No at on cards, and no page-wide boxes. notes say what the film does differently; honesty is unchanged.
  • scripts/record-scene.py: the overlay (cursor, caption bar, badge) is no longer drawn again inside a page shown inside the page. The 3D tab is an iframe, and without this the take showed two cursors and an empty second caption bar. A new test in tests/test_the_recorder_draws_a_cursor_and_a_box_a_viewer_can_follow.py fails without the fix.
  • tests/test_class_0_1_…: extended. It checks the voiced lines, where boxes go, the exempt lines, label length, the one spotlight, the gotos and the clicks.

Where it differs from the handoff, and why

  • Two gotos, not one. The first opens line FORK1. The second comes straight after the cards: a card is the recorder's own page and has no menu, so the class returns to the Line page by address and clicks everything from there.
  • The 3D drawing is the Line page's 3D tab, not the full-screen 3D page the first take opened on. The full-screen page draws its menus under the canvas, so nothing on it can be clicked to leave it. Product gap.
  • Lines said over the drawing have no box. The drawing is an iframe, and the box is drawn on the outer page. The drawing's readout carries the order, good and scrap.
  • Some labels were dropped. The recorder refuses a label with no clear spot outside its box: the tile meta, the tree rows, the stacker and wrapper heads, and the window list. Those boxes stand alone.

Product gaps (not fixed here; no product changes in this PR)

  • /dashboard/line/3d draws the nav under the canvas, so its menus cannot be clicked.
  • The Line page opened straight on its 3D tab (#scene) leaves its heading and facts blank ("—"). The hook therefore opens on the line and clicks the 3D tab.
  • Leaving the Line page after its 3D tab was opened and then hidden again freezes navigation for 3–7 s. Take 2 lost 20 s to it and its teaser went over 45 s, so the hook now goes to the cards with the drawing still showing.

How it was verified

  • The take ran to the end on a scratch plant (127.0.0.1:8040/4844, 10×). The badge is on 222/222 GIF frames and 5745/5745 mp4 frames.
  • Every still was looked at.
  • Every box (16), label (8) and press (11) in marks.json is inside the frame, below the header, above the 72 px caption bar, and clear of the narrator's corner.
  • sha256 of every other file under ~/Work/gifs/course before and after: identical, 136 files, none added or removed. Only the 0.1 folder and course.json changed.
  • course.json still records five classes; 0.1 went from take 2 to take 4. Take 3 also ran to the end, but one box came out empty, so it was filmed again.
  • ruff check . is clean.
  • pytest -m browser on the scene, course, recorder and class tests: 26 passed.
  • Fast suite: green, except one test outside this change that fails after about 18:00 local. test_the_calibration_the_supervisor_records_is_on_the_gauges_own_register compares a UTC date with date.today(). It is not touched here.

🤖 Generated with Claude Code

kalwei and others added 3 commits November 16, 2026 19:30
A page the product shows inside a page (the Line page's 3D tab) is a
document of its own, and the overlay script ran there too: the first take
of class 0.1's second filming had a second cursor and an empty caption
bar inside the drawing. The script now returns early in any frame that
is not the top one, and a browser test opens a page inside a page and
finds nothing drawn in the inner one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
The same 34 voiced lines, word for word (the fixture is the current take's
script file), with a box on what each line over the screen is about and
the path clicked: the Line page's 3D tab for FORK1, Overview, then after
the cards the Engineering menu, the machines tree, the mould, its own
trail back to the line, the Line list for the stacker, the wrapper and
the pallet line, and the 3D tab. The full-screen 3D page the first
filming opened on draws its menus under the drawing, so nothing on it can
be clicked; the class uses the Line page's 3D tab instead. Budget 360 to
390 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
Leaving the Line page after its drawing was opened and hidden again
holds the navigation for seconds (7 s with the camera on), which put
20 s of frozen page into the teaser and took it past 45 s. The hook now
opens on the line, boxes its name, and clicks the 3D tab for the three
lines the drawing's readout carries; the cards follow with the drawing
still showing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scottkalw <scottkalwei@gmail.com>
@github-actions

Copy link
Copy Markdown

Thanks for the first pull request. Checks: every commit signed off (git commit -s), ruff and pytest green, and the house-rules checklist in the template. The maintainer reviews within a few days.

@kalwei
kalwei merged commit 47ccf32 into main Nov 17, 2026
48 of 49 checks passed
@kalwei
kalwei deleted the feat/course-refilm-class-01 branch November 17, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant