Repository navigation
Class 0.1 filmed again: a cursor that clicks, boxes with labels, menus clicked - #262
Merged
Merged
Conversation
A page the product shows inside a page (the Line page's 3D tab) is a document of its own, and the overlay script ran there too: the first take of class 0.1's second filming had a second cursor and an empty caption bar inside the drawing. The script now returns early in any frame that is not the top one, and a browser test opens a page inside a page and finds nothing drawn in the inner one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
The same 34 voiced lines, word for word (the fixture is the current take's script file), with a box on what each line over the screen is about and the path clicked: the Line page's 3D tab for FORK1, Overview, then after the cards the Engineering menu, the machines tree, the mould, its own trail back to the line, the Line list for the stacker, the wrapper and the pallet line, and the 3D tab. The full-screen 3D page the first filming opened on draws its menus under the drawing, so nothing on it can be clicked; the class uses the Line page's 3D tab instead. Budget 360 to 390 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
Leaving the Line page after its drawing was opened and hidden again holds the navigation for seconds (7 s with the camera on), which put 20 s of frozen page into the teaser and took it past 45 s. The hook now opens on the line, boxes its name, and clicks the 3D tab for the three lines the drawing's readout carries; the cards follow with the drawing still showing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scottkalw <scottkalwei@gmail.com>
|
Thanks for the first pull request. Checks: every commit signed off ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Scott will see
Class 0.1, "What a factory does all day", filmed again the way 2.1 was in #259. It is 287 s long (take 4) and fits its 390 s budget. You see a cursor move and click, cyan boxes with short labels outside them, and every page after the first reached by clicking a menu, a tab, the tree or the page's own trail.
Stills (in
~/Work/gifs/course/01-before-the-software/01-what-a-factory-does-all-day/stills/):01-hook.png: line FORK1's 3D tab, with the order, good and scrap in the drawing's readout02-five-words.png: the first card03-tree.png: Engineering clicked; the tree, with "work center" boxed04-the-mould.png: FORK1_Mold clicked in the tree; its order, step and cost center05-stacker.png: STACK07LINE picked from the Line list; its order boxed06-pallet.png: the pallet line's 3D tab07-before-first-sample.png: the OEE tab; "before first sample" spotlighted, labelled "Nobody reported"08-you-now-know.png: the closing cardThe 34 spoken lines are byte-identical to the voiced take.
tests/fixtures/course/class-0-1-voiced-script.txtholds them, and the test asserts them.What changed
scripts/scenes/course/01-01-what-a-factory-does-all-day.toml: the path is clicked. Asaythat talks about something on screen hasat, and some have a short label. One spotlight is on "before first sample". Noaton cards, and no page-wide boxes.notessay what the film does differently;honestyis unchanged.scripts/record-scene.py: the overlay (cursor, caption bar, badge) is no longer drawn again inside a page shown inside the page. The 3D tab is an iframe, and without this the take showed two cursors and an empty second caption bar. A new test intests/test_the_recorder_draws_a_cursor_and_a_box_a_viewer_can_follow.pyfails without the fix.tests/test_class_0_1_…: extended. It checks the voiced lines, where boxes go, the exempt lines, label length, the one spotlight, the gotos and the clicks.Where it differs from the handoff, and why
Product gaps (not fixed here; no product changes in this PR)
/dashboard/line/3ddraws the nav under the canvas, so its menus cannot be clicked.#scene) leaves its heading and facts blank ("—"). The hook therefore opens on the line and clicks the 3D tab.How it was verified
marks.jsonis inside the frame, below the header, above the 72 px caption bar, and clear of the narrator's corner.~/Work/gifs/coursebefore and after: identical, 136 files, none added or removed. Only the 0.1 folder andcourse.jsonchanged.course.jsonstill records five classes; 0.1 went from take 2 to take 4. Take 3 also ran to the end, but one box came out empty, so it was filmed again.ruff check .is clean.pytest -m browseron the scene, course, recorder and class tests: 26 passed.test_the_calibration_the_supervisor_records_is_on_the_gauges_own_registercompares a UTC date withdate.today(). It is not touched here.🤖 Generated with Claude Code