Conversation
Signed-off-by: lprnmns <manasalperen@gmail.com>
lprnmns
marked this pull request as ready for review
August 31, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An empty Bearer credential (
Authorization: Bearer) currently reaches token decoding and returns HTTP 500 withmissing token. This malformed authentication input should use the existing HTTP 400 Bad Request path.Fix
Require a non-empty token before accepting the two-part Bearer header. The existing
FST_JWT_BAD_REQUESTerror and message are reused.Tests
node --test test/malformed-authorization.test.js- passed after the fix; the pre-fix run failed with500 !== 400npm test- passed; 179 unit tests, 100% coverage, and 44 TSTyche assertionsgit diff --check- passedCompatibility
Only an empty Bearer value changes behavior. Valid Bearer tokens and the other authentication branches remain covered by the full suite.
Related issue
Independent reproduction; final searches found no matching open issue or pull request.