Reject non-SP proxy CONNECT whitespace - #1324
Merged
fewensa merged 1 commit intoOct 1, 2026
Merged
Conversation
codeon:
version: 1
authority: FWN-4
description: |-
Reject HTAB and Unicode whitespace anywhere in proxy CONNECT response status lines while preserving ASCII-space separators. Move sync and async regression cases for non-SP reason-phrase whitespace into rejection coverage.
Tests:
- cargo fmt --all -- --check
- cargo test -p rttp_client test_parse_proxy_connect_response_ -- --nocapture
- cargo test -p rttp_client --features async async_read_proxy_connect_response_rejects_non_sp -- --nocapture
- cargo test -p rttp_client --features async async_read_proxy_connect_response_accepts_ascii_sp -- --nocapture
- git diff --quiet -- crates/rttp-protocol/src/http1.rs
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
fewensa
deleted the
codeon/fewensa/FWN-4/a6-eca2f518728e4cfeb1c872994c4e836c
branch
October 1, 2026 04:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject HTAB and Unicode whitespace anywhere in proxy CONNECT response status lines with a CONNECT-local validation guard, while preserving ASCII space separators and leaving shared HTTP/1 parsing unchanged.
Added sync and async regression coverage for HTAB, NBSP, and EM SPACE in reason phrases; these are now rejected alongside non-SP status-line separators.
Tests:
Closes #1164