Cover h2c Upgrade RST_STREAM while response flow-control is blocked - #1327
Merged
fewensa merged 1 commit intoOct 1, 2026
Merged
Conversation
codeon:
version: 1
authority: FWN-7
description: |-
Add an Upgrade: h2c twin of the prior-knowledge regression so a peer RST_STREAM during flow-control-blocked response DATA cannot resume writing, connection WINDOW_UPDATE does not revive the reset stream, the next stream still serves, and the server joins cleanly.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
fewensa
deleted the
codeon/fewensa/FWN-7/a1-deb0412532c74f41bc7a3befa1edabb9
branch
October 1, 2026 05:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Upgrade: h2c regression coverage for RST_STREAM while response DATA is blocked by flow control.
Mirrors the prior-knowledge case via complete_h2c_upgrade on streams 3 then 5: writing stops after reset, connection WINDOW_UPDATE does not resume reset-stream DATA, the next stream still serves, and the server joins cleanly. Prior-knowledge behavior is unchanged; production code was not required.
Closes #1326