Test h2c Upgrade rejection of malformed PING frames - #1328
Merged
fewensa merged 1 commit intoOct 1, 2026
Merged
Conversation
codeon:
version: 1
authority: FWN-8
description: |-
Add table-driven h2c Upgrade regression coverage for malformed HTTP/2 PING frames. The peer completes the Upgrade and HTTP/2 setup, verifies stream 3 request headers, then sends invalid stream-id, payload-length, and ACK-payload variants. Assert the exact protocol diagnostic, reject builder/status classifications, and join each peer thread cleanly.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
fewensa
deleted the
codeon/fewensa/FWN-8/a1-dc6952fcd08742ecac7a5c68cf4330a5
branch
October 1, 2026 05:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds table-driven RTTP client coverage for malformed HTTP/2 PING frames received during an HTTP/1.1 Upgrade: h2c response. The test covers wrong stream ID, invalid payload length, and invalid ACK payload, verifies the exact typed protocol diagnostic before any response is exposed, and joins each peer thread cleanly. No production code changes.