ci: give release/v0.13 its own release-PR branch prefix - #151
Merged
Merged
Conversation
release-plz matches its open release PR by head-branch prefix only. With the default prefix a run on this branch took over main's release PR (#132) and force-pushed 0.13.1 onto it.
hts-sys 2.2.1 did not change htslib; it regenerated bindings with bindgen 0.72, which renamed isize to isize_ and size_t to usize. And the semver check only needs to stay off until 0.13.1 is the published baseline.
Once 0.14.0 exists, a later 0.13.x would otherwise become GitHub's latest release, which ft-update and releases/latest/download follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-plz 0.3.168 locates its open release PR with
opened_prs(pr_branch_prefix), which filters on the head branch name only and never on the base branch. Both branches used the defaultrelease-plz-, so the run after #150 merged found #132 (main's 0.14.0 release PR), force-pushed the 0.13.1 release onto its branch, and retitled it. #132 has been retargeted torelease/v0.13and is now the correct 0.13.1 release PR.This sets
pr_branch_prefix = "release-v0.13-"on this branch so future runs here create and update onlyrelease-v0.13-*PRs, and main's runs (default prefix) never see them. The old-prefix fallback in release-plz isrelease-plz/, which also does not match.Merge after #132. Merging this before #132 would make the next run here open a second 0.13.1 PR under the new prefix.