Skip to content

INTER-2535: ci: deploy docs and coverage via shared Pages workflow - #286

Merged
JuroUhlar merged 2 commits into
mainfrom
uhlar/trusting-lovelace-r1vw4y
Sep 15, 2026
Merged

INTER-2535: ci: deploy docs and coverage via shared Pages workflow#286
JuroUhlar merged 2 commits into
mainfrom
uhlar/trusting-lovelace-r1vw4y

Conversation

@JuroUhlar

@JuroUhlar JuroUhlar commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Use the released shared docs-and-coverage.yml@v1 Pages artifact pipeline
  • Grant the caller permissions required for deployment

Required repository setting

Set Settings → Pages → Build and deployment → Source to GitHub Actions before merging. After the first successful deployment, the unused gh-pages branch can be removed.

@claude
ci: deploy docs and coverage via GitHub Pages pipeline
9e52c21 
The shared docs-and-coverage workflow publishes by pushing a commit to
the gh-pages branch with JamesIves/github-pages-deploy-action. That
commit is unsigned, so the repository ruleset requiring verified
signatures on gh-pages rejects the push and the job fails.

Replace the reusable workflow call with a local job that runs the same
build, docs, coverage and badge steps, then publishes through the
official Pages pipeline (configure-pages, upload-pages-artifact,
deploy-pages). This uploads an artifact instead of pushing a branch
commit, so the signature rule no longer applies.

Requires the repository Pages source to be set to "GitHub Actions".

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CVQ7VL2PnxZcxTU4AZt43h
@JuroUhlar
JuroUhlar requested a lite review from Copilot September 11, 2026 13:59
@changeset-bot

changeset-bot Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 015ff88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 98.21% 165/168
🟢 Branches 97.03% 98/101
🟢 Functions 100% 35/35
🟢 Lines 98.19% 163/166

Test suite run success

130 tests passing in 30 suites.

Report generated by 🧪jest coverage report action from 015ff88

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 98.21 97.02 100 98.19
🟢  src 98.5 98.76 100 98.49
🔴   ...edApiTypes.ts 0 0 0 0
🔴   index.ts 0 0 0 0
🟢   sealedResults.ts 100 100 100 100
🟢   ...rApiClient.ts 96.15 97.22 100 96.15 358,362
🟢   types.ts 100 100 100 100
🟢   urlUtils.ts 100 100 100 100
🟢   webhook.ts 100 100 100 100
🟢  src/errors 97.05 90 100 96.96
🟢   apiErrors.ts 100 100 100 100
🟢   ...orResponse.ts 100 100 100 100
🟢   toError.ts 87.5 88.88 100 87.5 21
🟢   unsealError.ts 100 50 100 100 10

Copilot AI reviewed Sep 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved blocking issues were identified.

Pull request overview

Replaces branch-based docs and coverage publishing with GitHub Pages artifact deployment.

Changes:

  • Runs build, docs, coverage, and badge generation locally.
  • Uploads and deploys the assembled site via GitHub Pages.
  • Adds required permissions, environment, and concurrency settings.
File summaries
File Description
.github/workflows/coverage-report.yml Implements the docs, coverage, and GitHub Pages deployment pipeline.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@JuroUhlar
JuroUhlar marked this pull request as ready for review September 14, 2026 11:27
@JuroUhlar JuroUhlar changed the title ci: deploy docs and coverage via GitHub Pages pipeline INTER-2535: ci: deploy docs and coverage via GitHub Pages pipeline Sep 14, 2026
@JuroUhlar JuroUhlar mentioned this pull request Sep 14, 2026
Merged
@JuroUhlar JuroUhlar changed the title INTER-2535: ci: deploy docs and coverage via GitHub Pages pipeline INTER-2535: ci: deploy docs and coverage via shared Pages workflow Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@JuroUhlar
JuroUhlar requested a lite review from Copilot September 14, 2026 22:29
Copilot AI reviewed Sep 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues remain.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@JuroUhlar
JuroUhlar merged commit 296561f into main Sep 15, 2026
20 checks passed
@JuroUhlar
JuroUhlar deleted the uhlar/trusting-lovelace-r1vw4y branch September 15, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@ilfa ilfa ilfa approved these changes
@Orkuncakilkaya Orkuncakilkaya Awaiting requested review from Orkuncakilkaya Orkuncakilkaya is a code owner
@makma makma Awaiting requested review from makma makma is a code owner
@mcnulty-fp mcnulty-fp Awaiting requested review from mcnulty-fp mcnulty-fp is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JuroUhlar @ilfa @claude