Repository navigation
INTER-2639: fix: update docs links in v3 Server API schemas - #489
Conversation
Point `get-function` links at the v3 JS agent page, which still has the `requestid`, `visitorid` and `linkedid` anchors. Move migration guide links to docs.fingerprint.com and use the anchor IDs the page renders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S6AuB1xNKrrrmVKPX5vExu
|
Schema Diff vs Published Schemas
|
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only updates are consistent across the affected v3 schemas and leave API behavior unchanged.
0 open findings
What changed in this PR
Updates broken documentation links in deprecated v3 Server API schemas without changing API behavior.
Changes:
- Redirects JavaScript Agent references to v3 documentation.
- Corrects migration guide domains and anchors.
| File | Description |
|---|---|
schemas/fingerprint-server-api-for-sdks.yaml |
Updates v3 SDK schema documentation links. |
schemas/fingerprint-server-api-readme-explorer.yaml |
Updates corresponding ReadMe explorer links. |
schemas/fingerprint-related-visitors-api-readme-explorer.yaml |
Fixes migration and visitor ID links. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Replace the remaining dev.fingerprint.com links with their final docs.fingerprint.com URLs. Use v3 pages where they exist (glossary, regions, smart signals, Suspect Score, webhooks, Server API v3 reference). smart-signals-overview now lives at smart-signals-reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S6AuB1xNKrrrmVKPX5vExu
|
I don't think this PR causes it. The test sends a real update request to the live API, and the result depends on that event's state in the test subscription, not on the schema. This PR only changes link URLs in descriptions. The same job passed on the previous commit (864ef65), which had the same kind of change. Lint, build, schema lint and unit tests pass locally on this commit. I'm re-running the failed job once to confirm. Generated by Claude Code |
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only URL updates are consistent across the affected v3 schemas with no unresolved issues.
0 open findings
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Looks like some test flake that is worth fixing or tracking as a known issue. |
|
Agreed. The cause is a timing race in One possible fix: if the update succeeds, log a warning and skip the live check for that subscription instead of failing. The example-file check still covers the schema. A retry with a new event would also work, but it can still race. This is unrelated to this PR's change, so I'd handle it in a separate PR or issue. I'll check with the PR author which they prefer. Generated by Claude Code |
pnpm run changesetto create a changeset. |
Sorry for the slop reply, Claude got away from me. But he is right, I will try fixing it in a separate PR. The link updates themeselces should be ready for review, did some spot checks and lgtm. |
Part of INTER-2639.
Fixes broken links in the v3 Server API schemas and moves every link from
dev.fingerprint.comtodocs.fingerprint.com. docs.fingerprint.com renders these schemas, so broken links show up there too.Changes:
get-function#requestid,#visitoridand#linkedidnow point todocs.fingerprint.com/reference/v3/js-agent-get-function. The old URL redirects to the v4 page, which doesn't have these anchors.#migrating-get-/events,#migrating-get-/events/search,#migrating-get-/visitorsand#migrating-update-/events.dev.fingerprint.comlinks now go directly to their finaldocs.fingerprint.comURL. Where a v3 page exists, they use it:docs/glossary,regions,suspect-score,webhooks→docs/v3/...docs/smart-signals-overviewandsmart-signals-reference→docs/v3/smart-signals-referencereference/getevent,updateevent,getvisits,pro-server-api→reference/v3/server-api-*reference/api-deprecation-policy,related-visitors-api→ same path ondocs.fingerprint.comEvery new URL returns 200 and every anchor exists on the live page (checked with curl). No
dev.fingerprint.comlinks remain in these files.Files changed:
fingerprint-server-api-for-sdks.yaml(the source offingerprint-server-api.yaml),fingerprint-server-api-readme-explorer.yamlandfingerprint-related-visitors-api-readme-explorer.yaml. The v4 schema doesn't change.Checks:
pnpm build,lintSchema,lintSchemaDistandtestpass. Lint warnings are the same as onmain, except for one new info-leveldescription-duplicationnote.This only changes descriptions, so there's no changeset.
🤖 Generated with Claude Code
https://claude.ai/code/session_01S6AuB1xNKrrrmVKPX5vExu