Repository navigation
INTER-2472: Update schema URL and harden sync script - #281
Merged
Merged
Conversation
Update the OpenAPI schema URL. Use an `env bash` shebang so the script picks up bash from PATH rather than whatever sits at /bin/bash. Harden `curl` to refuse redirects that leave https and to bound connect and transfer time, so a stalled download cannot hang CI or a local run. Document `./scripts/sync.sh` and `./scripts/generate.sh` instead of invoking them through `sh`. Related-Task: INTER-2472
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Failed downloads can leave truncated schema or mock files in the checkout.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates schema synchronization for the pending OpenAPI repository rename and improves download reliability.
Changes:
- Updates the default GitHub Pages schema URL.
- Adds curl protocol restrictions and timeouts.
- Documents executable script invocation.
| File | Description |
|---|---|
scripts/sync.sh |
Updates URLs, curl options, paths, and progress output. |
contributing.md |
Uses executable scripts directly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🟢 Coverage increased by 97.54% Code Coverage ReportCoverage Report
Files Coverage
|
Contributor
pnpm exec changesetto create a changeset. |
erayaydin
marked this pull request as ready for review
September 25, 2026 09:06
erayaydin
requested review from
Orkuncakilkaya,
TheUnderScorer and
ilfa
as code owners
September 25, 2026 09:06
Orkuncakilkaya
approved these changes
Sep 25, 2026
erayaydin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub redirects repository URLs after a rename but explicitly not project GitHub Pages URLs, so
sync.shwill start failing with a 404. This PR changes the default OpenAPI schema URL.Alongside the URL change, use
env bashshebang, so the script picks up bash from the correct environment. Hardencurlto refuse redirects that leave https and bound connect and transfer time so a stalled download cannot hang CI or local. Hoist the destination paths intoschemaDestinationandbaseDestination, and derive the schema directory from them.Separately,
contributing.mddocumentedsh ./scripts/sync.shandsh ./scripts/generate.sh. Both are executable, so the documented commands are now./scripts/sync.shand./scripts/generate.sh, which honor the shebang. This is pre-existing and unrelated to the rename.