chore: fix coverage report publishing to GH pages - #285
Merged
Merged
Conversation
Contributor
pnpm exec changesetto create a changeset. |
Contributor
|
🟢 Coverage increased by 97.52% Code Coverage ReportCoverage Report
Files Coverage
|
mcnulty-fp
marked this pull request as ready for review
September 28, 2026 15:19
mcnulty-fp
requested review from
Orkuncakilkaya,
TheUnderScorer,
erayaydin and
ilfa
as code owners
September 28, 2026 15:19
erayaydin
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that signed commits are required,
JamesIves/github-pages-deploy-actioncan no longer push to thegh-pagesbranch. Followed the same solution from this PR: fingerprintjs/python-sdk#228Changes:
gh-pagesbranch push withactions/upload-pages-artifact+actions/deploy-pagesdeploy-pagesjob to complete GH pages deploymentcontents: writepermission, since nothing pushes to a branch anymoreSwitch the Pages source to GitHub Actions. More details here. Requires repo admin, so someone with that access will need to run this (from the UI, or via the
ghAPI command below):Slack ref relevant to this process: https://fingerprintjs.slack.com/archives/C050TKU9X5L/p1788168387519619