[api-v3] INTER-2472: Update schema URL and harden sync script - #235
Merged
Merged
Conversation
Update the OpenAPI schema URL. Use an `env bash` shebang so the script picks up bash from PATH rather than whatever sits at /bin/bash. Resolve paths relative to the repository root, so the script no longer writes into whatever directory it is invoked from. Collect the curl flags into `CURL_OPTS`, gated on `TRACE` and `ACTIONS_STEP_DEBUG` so runs can be made verbose, and add hardening: refuse redirects that leave https, and bound connect and transfer time so a stalled download cannot hang CI or a local run. Log the download. Inline the base URL into `schemaUrl`. Related-Task: INTER-2472
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
pnpm exec changesetto create a changeset. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Interrupted transfers can overwrite the valid schema with partial content, and the prerequisite repository rename remains incomplete.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates schema synchronization for the planned OpenAPI repository rename while improving script portability and curl safeguards.
Changes:
- Updates the default schema URL.
- Resolves paths from the repository root.
- Adds curl failure handling, timeouts, retries, and configurable verbosity.
| File | Description |
|---|---|
sync.sh |
Hardens schema downloading and updates its source URL. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
erayaydin
marked this pull request as ready for review
September 25, 2026 09:05
erayaydin
changed the title
ilfa
approved these changes
Sep 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub redirects repository URLs after a rename but explicitly not project GitHub Pages URLs, so
sync.shwill start failing after the rename. This PR changes the default OpenAPI schema URL.curlran without-f, which made that failure silent. With-fthe same request exits 56 and leaves the existing file untouched.Alongside the URL change, use
env bashshebang, so the script picks up bash from the correct environment. Resolve paths relative to the repository root, so the script no longer writes into whatever directory it is invoked from. Collect thecurlflags intoCURL_OPTS, gated onTRACEandACTIONS_STEP_DEBUGso runs can be made verbose, and add hardening to refuse redirects that leave https and bound connect and transfer time so a stalled download cannot hang CI or local. Log the download.Inline the base URL into
schemaUrl.