[INTER-970] Add support for new arch

.changeset/new-architecture-support.md

@@ -0,0 +1,7 @@
+---
+'@fingerprintjs/fingerprintjs-pro-react-native': major
+---
+
+Dropped React Native Old Architecture support. The native module is now a TurboModule (New Architecture only) exposed via a Codegen spec. 
+
+This is a breaking change: the SDK now requires React Native >= 0.79 (Expo SDK >= 53) with the [New Architecture](https://reactnative.dev/architecture/landing-page) enabled.

.changeset/pre.json

@@ -0,0 +1,8 @@
+{
+  "mode": "pre",
+  "tag": "rc",
+  "initialVersions": {
+    "@fingerprintjs/fingerprintjs-pro-react-native": "3.17.0"
+  },
+  "changesets": []
+}

.github/workflows/e2e-tests.yml

@@ -18,7 +18,7 @@ jobs:
     steps:
       - id: set-matrix
         run: |
-          echo "matrix=['local', '0.73', '0.74', '0.75', '0.76', '0.77', '0.79', '0.81', '0.83', '0.85']" >> $GITHUB_OUTPUT
+          echo "matrix=['local', '0.79', '0.81', '0.83', '0.85']" >> $GITHUB_OUTPUT
 
   build-android:
     strategy:
@@ -81,11 +81,14 @@ jobs:
         run: rm -rf node_modules && pnpm install --frozen-lockfile
         working-directory: e2e-app
 
+      - run: pnpm why react-native
+        working-directory: e2e-app
+
       - name: Prebuild
         run: pnpm prebuild
         working-directory: e2e-app
 
-      - run: pnpm exec detox build --configuration android.emu.release
+      - run: node scripts/retry-cmd.mjs --retries=3 "pnpm exec detox build --configuration android.emu.release"
         working-directory: e2e-app
 
       - name: Upload artifacts
@@ -191,8 +194,9 @@ jobs:
           emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
           disable-animations: true
           arch: x86_64
+          working-directory: e2e-app
           avd-name: ${{ steps.device.outputs.AVD_NAME }}
-          script: cd e2e-app && pnpm exec detox test --configuration android.emu.release --headless --record-logs all --record-videos failing
+          script: node scripts/retry-cmd.mjs --retries=3 "pnpm exec detox test --configuration android.emu.release --headless --record-logs all --record-videos failing"
 
       - name: Upload artifacts
         if: always()
@@ -277,11 +281,14 @@ jobs:
         run: rm -rf node_modules && pnpm install --frozen-lockfile
         working-directory: e2e-app
 
+      - run: pnpm why react-native
+        working-directory: e2e-app
+
       - name: Prebuild
         run: pnpm prebuild
         working-directory: e2e-app
 
-      - run: pnpm exec detox build --configuration ios.sim.release
+      - run: node scripts/retry-cmd.mjs --retries=3 "pnpm exec detox build --configuration ios.sim.release"
         working-directory: e2e-app
 
       - name: Upload artifacts
@@ -355,7 +362,7 @@ jobs:
         if: github.event_name != 'release'
         working-directory: e2e-app
 
-      - run: pnpm exec detox test --configuration ios.sim.release --cleanup --headless --record-logs all --record-videos failing
+      - run: node scripts/retry-cmd.mjs --retries=3 "pnpm exec detox test --configuration ios.sim.release --cleanup --headless --record-logs all --record-videos failing"
         working-directory: e2e-app
         env:
           MINIMUM_US_DEFAULT_PUBLIC_KEY: ${{ secrets.MINIMUM_US_DEFAULT_PUBLIC_KEY }}

README.md

@@ -62,8 +62,8 @@ application to call the native Fingerprint Pro libraries (Android and iOS) and i
 
 ## Requirements and limitations
 
-- React Native versions 0.73 through 0.86 are supported
-- Expo 51.0.0 or higher is supported
+- React Native 0.79 or higher is supported (New Architecture only)
+- Expo 53.0.0 or higher is supported
 - Android 6.0 (API level 23+) or higher
 - iOS 13+/tvOS 15+, Swift 5.9 or higher (stable releases)
 

e2e-app/App.tsx

@@ -1,15 +1,23 @@
 // SafeAreaView is deprecated in newer RN versions, react-native-safe-area-context is recommended
 // but it doesn't work nicely with older RN versions that we also run tests against, so keep SafeAreaView import from react-native for now
+/* eslint-disable @typescript-eslint/no-deprecated */
 import { Pressable, SafeAreaView, Text, View } from 'react-native'
 import { FingerprintJsProProvider, useVisitorData } from '@fingerprintjs/fingerprintjs-pro-react-native'
 import { testIds } from '@/e2e/ids'
 import { useEffect } from 'react'
 import { testTags } from '@/e2e/tags'
 import config from '@/src/config'
+import { ArchInfo } from '@/src/components/ArchInfo'
 
 function InnerApp() {
   const { isLoading, error, data, getData } = useVisitorData()
 
+  const doGetData = async () => {
+    const tags = config.useTags ? testTags : undefined
+
+    await getData(tags, config.linkedId)
+  }
+
   useEffect(() => {
     if (error) {
       console.error(error)
@@ -18,7 +26,6 @@ function InnerApp() {
 
   return (
     <View style={{ flex: 1 }}>
-      {/* eslint-disable-next-line @typescript-eslint/no-deprecated */}
       <SafeAreaView
         style={{
           padding: 24,
@@ -27,6 +34,7 @@ function InnerApp() {
           flex: 1,
         }}
       >
+        <ArchInfo />
         {isLoading ? <Text testID={testIds.loading}>Loading...</Text> : null}
         {error ? (
           <View>
@@ -37,20 +45,23 @@ function InnerApp() {
           </View>
         ) : null}
         {data ? <Text testID={testIds.data}>{JSON.stringify(data)}</Text> : null}
-        <Pressable
-          testID={testIds.getData}
-          onPress={async () => {
-            const tags = config.useTags ? testTags : undefined
 
-            await getData(tags, config.linkedId)
-          }}
-          style={{
-            paddingBottom: 48,
-            paddingLeft: 24,
-          }}
-        >
-          <Text>Get data</Text>
-        </Pressable>
+        <View style={{ marginTop: 24, marginBottom: 24, alignItems: 'center' }}>
+          <Pressable
+            testID={testIds.getData}
+            onPress={doGetData}
+            style={{
+              padding: 12,
+              backgroundColor: '#2196F3',
+              borderRadius: 8,
+              marginBottom: 12,
+              minWidth: 200,
+              alignItems: 'center',
+            }}
+          >
+            <Text style={{ color: '#ffffff', fontWeight: 'bold' }}>Get data</Text>
+          </Pressable>
+        </View>
       </SafeAreaView>
     </View>
   )

e2e-app/app-config-tools/android.ts

@@ -14,24 +14,6 @@ const androidBuildProperties: AndroidBuildProperties = {
   enableBundleCompression: false,
 }
 
-export function withAndroidBuildProperties(props: Partial<AndroidBuildProperties>) {
-  return () => {
-    Object.assign(androidBuildProperties, props)
-  }
-}
-
-export function setCompileSdkVersion(version: number) {
-  return withAndroidBuildProperties({
-    compileSdkVersion: version,
-  })
-}
-
-export function stripAndroidExtraBuildProperties() {
-  delete androidBuildProperties.compileSdkVersion
-  delete androidBuildProperties.targetSdkVersion
-  delete androidBuildProperties.buildToolsVersion
-}
-
 export function getAndroidBuildProperties() {
   return { ...androidBuildProperties }
 }

e2e-app/app-config-tools/reactNativeMetadata.ts

@@ -1,7 +1,3 @@
-import { disableNewArch } from './arch'
-import { setCompileSdkVersion, stripAndroidExtraBuildProperties } from './android'
-import { withFingerprintMavenRepo, withNewArchFlag, withSplashscreen } from './expoConfigPatchers'
-
 // config is typed as any, as different expo version have different types for the config object
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 type ExpoConfigPatcher = (config: any) => void
@@ -19,29 +15,11 @@ type ReactNativeMetadata = {
  * - The key represents the version of React Native.
  * - The value is an object containing:
  *   - `callbacks`: An array of functions to execute in the context of the respective React Native version.
+ *
+ * The SDK supports React Native >= 0.79 (New Architecture only), so no version currently needs
+ * version-specific handling. New entries can be added here if a future version requires it.
  */
-const reactNativeMetadata: Record<string, ReactNativeMetadata | undefined> = {
-  0.73: {
-    callbacks: [disableNewArch, stripAndroidExtraBuildProperties, setCompileSdkVersion(34)],
-    patchExpoConfig: [withNewArchFlag, withSplashscreen, withFingerprintMavenRepo],
-  },
-  0.74: {
-    callbacks: [disableNewArch, stripAndroidExtraBuildProperties, setCompileSdkVersion(34)],
-    patchExpoConfig: [withNewArchFlag, withSplashscreen],
-  },
-  0.75: {
-    callbacks: [disableNewArch, stripAndroidExtraBuildProperties, setCompileSdkVersion(34)],
-    patchExpoConfig: [withNewArchFlag, withSplashscreen],
-  },
-  0.76: {
-    callbacks: [stripAndroidExtraBuildProperties, setCompileSdkVersion(35)],
-    patchExpoConfig: [withNewArchFlag, withSplashscreen],
-  },
-  0.77: {
-    callbacks: [stripAndroidExtraBuildProperties, setCompileSdkVersion(35)],
-    patchExpoConfig: [withNewArchFlag, withSplashscreen],
-  },
-}
+const reactNativeMetadata: Record<string, ReactNativeMetadata | undefined> = {}
 
 export function handleReactNativeVersion(rnVersion: string) {
   if (reactNativeMetadata[rnVersion]?.callbacks?.length) {

e2e-app/app.config.ts

@@ -48,4 +48,8 @@ const config: ExpoConfig = {
   ],
 }
 
+// The SDK supports the New Architecture only (React Native >= 0.79), so always enable it.
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+;(config as any).newArchEnabled = true
+
 export default patchExpoConfig(rnVersionStr, config)

e2e-app/e2e/arch.test.ts

@@ -0,0 +1,39 @@
+import { by, device, element, waitFor } from 'detox'
+import { beforeAll, describe, expect, it, jest } from '@jest/globals'
+import { DeviceLaunchAppConfig } from 'detox/detox'
+import { wait } from './wait'
+import { Config } from '@/src/config.types'
+import { testIds } from './ids'
+import { getElementText } from './getElementText'
+
+async function launchApp(params?: DeviceLaunchAppConfig) {
+  await device.launchApp(params)
+
+  await wait(4000)
+}
+
+jest.retryTimes(3, {
+  waitBeforeRetry: 1000,
+  logErrorsBeforeRetry: false,
+})
+
+describe('React Native architecture', () => {
+  beforeAll(async () => {
+    await launchApp({
+      newInstance: true,
+      launchArgs: {
+        apiKey: process.env.MINIMUM_US_DEFAULT_PUBLIC_KEY,
+        region: 'us',
+      } as Config,
+    })
+  })
+
+  it('runs on fabric', async () => {
+    await waitFor(element(by.id(testIds.uiManager)))
+      .toExist()
+      .withTimeout(10_000)
+
+    const uiManager = await getElementText(element(by.id(testIds.uiManager)))
+    expect(uiManager.toLowerCase()).toEqual('fabric')
+  })
+})

e2e-app/e2e/identification.test.ts

@@ -21,7 +21,7 @@ async function launchApp(params?: DeviceLaunchAppConfig) {
 }
 
 jest.retryTimes(3, {
-  waitBeforeRetry: 10_000,
+  waitBeforeRetry: 1000,
   logErrorsBeforeRetry: false,
 })
 

e2e-app/e2e/ids.ts

@@ -6,4 +6,5 @@ export const testIds = {
   errorCause: 'error-cause',
   data: 'data',
   getData: 'get-data',
+  uiManager: 'ui-manager',
 }

e2e-app/pnpm-workspace.yaml

@@ -4,3 +4,5 @@ allowBuilds:
   detox: true
   dtrace-provider: true
   esbuild: true
+
+shamefullyHoist: true