Repository navigation
Conversation
pnpm exec changesetto create a changeset. |
Coverage report
Test suite run success95 tests passing in 6 suites. Report generated by 🧪jest coverage report action from 60a991a Show full coverage report
|
There was a problem hiding this comment.
🟡 Changes recommended
The version regex can silently select an unrelated package requirement.
1 open finding
What changed in this PR
Derives the CocoaPods Fingerprint-iOS range from the SwiftPM manifest.
Changes:
- Reads the lower version from
Package.swift. - Computes the next-minor upper bound.
- Applies the derived range to the pod dependency.
| File | Description |
|---|---|
sdk/RNFingerprint.podspec |
Synchronizes the CocoaPods dependency range with SwiftPM. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -1,3 +1,9 @@ | |||
| # Keep CocoaPods and Swift Package Manager on the same patch range (Package.swift is the source of truth). | |||
| fingerprint_lower = File.read(File.join(__dir__, 'Package.swift'))[/\.upToNextMinor\(\s*from:\s*"([\d.]+)"\s*\)/m, 1] | |||
There was a problem hiding this comment.
I don't think we'll ever use any other dependency in the native module. We can still address it just to be extra safe; your call @kevinmia. One note: if we decide to address it, we should do the same in Flutter.
There was a problem hiding this comment.
It is your call. I like the suggested change because it is, even though crowded, a lot easier to make sense of because it explicitly mentions the repo URL. It is up to you guys, either way is fine
There was a problem hiding this comment.
nit: perhaps it would be useful to add a comment next to the Fingerprint-iOS in Package.swift that mentions which version format should be used so that the sync works here?

Ticket: https://fingerprintjs.atlassian.net/browse/INTER-2622
Mirroring the approach in the Flutter SDK's podspec. Note that the regex also tolerates the multi-line
.package(...)layout used insdk/Package.swift.Testing: Temporarily set
Package.swiftto 4.2.3, where it resolved to>= 4.2.3, < 4.3.0.