Fix release asset upload for github-script v7#52
Merged
Conversation
The publish workflow pins actions/github-script to a v7 commit, where REST methods moved under github.rest.*. The asset upload still called github.repos.uploadReleaseAsset, which is undefined on v7 and fails the upload step after the release is created. Use github.rest.repos.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.00% coverage variation (-1.00%) |
| Diff coverage | ✅ ∅ diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (4842a38) 3310 2235 67.52% Head commit (a62b429) 3310 (+0) 2235 (+0) 67.52% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#52) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
publishworkflow's asset-upload step fails on every tagged release. After the draft release is created, the Upload step errors with:Root cause
When the workflow actions were pinned to commit SHAs,
actions/github-scriptwas pinned to a v7 commit (3a2844b7…). In github-script v5+, the Octokit REST methods moved fromgithub.*togithub.rest.*. The inline upload script still callsgithub.repos.uploadReleaseAsset, which isundefinedon v7 — so the step throws and no assets are attached.The release is still created and tarballs are still built and uploaded as workflow artifacts; only the attach-to-release step fails.
Fix
Call
github.rest.repos.uploadReleaseAssetinstead. One line.The sibling
Create Releasestep usesactions/create-release(not github-script) and is unaffected.