[BHP1-1622] Fix Total Live and Dead Fuel Load returning NaN - #268
Merged
Conversation
Collaborator
|
Looks good, approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Total Live/Dead Fuel Load outputs were
NaNfor every run. Root cause is an uninitialized accumulator inbehave-mirror(firelab/behave#68). Pulls in the fixed submodule and rebuilds the WASM bundle.Related Issues
Closes BHP1-1622
Submission Checklist
BHP1-### <title>)clj-kondo --lint components/**/src bases/**/src projects/**/src)clojure -M:compile-cljs)Testing
163, wind speed5 mi/h, slope30%Total Live Fuel LoadandTotal Dead Fuel Loadoutputs1.1/2.15ton/ac instead ofNaNScreenshots