Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/src/commands/devices.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const { getClient, resolveBoxGid } = require('../api/client');
* Fetch all devices for a box (API returns a flat array, no pagination).
*/
async function fetchAll(client, gid) {
const { data } = await client.get('/devices', { params: { gid } });
const { data } = await client.get('/devices', { params: { box: gid } });
return Array.isArray(data) ? data : (data.results || []);
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"fw": "./src/index.js"
},
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
"test": "node --test"
},
"dependencies": {
"axios": "^1.6.0",
Expand Down
48 changes: 48 additions & 0 deletions test/devices.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
const test = require('node:test');
const assert = require('node:assert/strict');

test('devices fetch uses the API box selector', async () => {
const originalLoad = require.cache[require.resolve('../cli/src/commands/devices')];
delete require.cache[require.resolve('../cli/src/commands/devices')];

const clientPath = require.resolve('../cli/src/api/client');
const originalClient = require.cache[clientPath];
delete require.cache[clientPath];

try {
const apiClient = require('../cli/src/api/client');
const calls = [];
const fakeClient = {
get: async (path, config) => {
calls.push({ path, config });
return { data: [] };
}
};
const originalGetClient = apiClient.getClient;
const originalResolveBoxGid = apiClient.resolveBoxGid;
apiClient.getClient = () => fakeClient;
apiClient.resolveBoxGid = async () => 'box-a';

delete require.cache[require.resolve('../cli/src/commands/devices')];
const Devices = require('../cli/src/commands/devices');
const originalLog = console.log;
console.log = () => {};

try {
await Devices.list({ box: 'box-a' });
} finally {
console.log = originalLog;
apiClient.getClient = originalGetClient;
apiClient.resolveBoxGid = originalResolveBoxGid;
}

assert.deepEqual(calls, [
{ path: '/devices', config: { params: { box: 'box-a' } } },
]);
} finally {
if (originalClient) require.cache[clientPath] = originalClient;
else delete require.cache[clientPath];
if (originalLoad) require.cache[require.resolve('../cli/src/commands/devices')] = originalLoad;
else delete require.cache[require.resolve('../cli/src/commands/devices')];
}
});