Run the translator as a systemd system service - #85
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Qizot
approved these changes
Sep 9, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workflow now performs system-level systemctl and /etc/systemd/system writes without ensuring root/sudo privileges, which is likely to break deployments.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR migrates the translation demo’s “translator” process from a user-level systemd unit (systemctl --user) to a system-wide systemd service so it can survive SSH logouts and reboot cycles in the deployment environment.
Changes:
- Added a systemd system unit definition for the translator service.
- Updated the deployment workflow to install the unit into
/etc/systemd/system, reload systemd, enable, and restart the service.
File summaries
| File | Description |
|---|---|
translation-demo/service/deploy/translator.service |
Introduces a system-level systemd service definition for running the translator via uv. |
.github/workflows/translation-demo-deploy.yml |
Updates remote deploy steps to install and manage the system service instead of a user service. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.