Conversation
The register-input response now reports publish_url in place of port.
The server now reports a complete publish URL, so the caller no longer has to build one from the composition origin and a port.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR description flags a required documentation update for this breaking change, but no documentation changes are included.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the Composition client to reflect a server-side change where RTMP inputs now return a full publish URL (instead of a derivable port), and exposes that URL via registerRtmpInput.
Changes:
- Regenerates the Composition OpenAPI client model to replace
RegisterInputResponse.portwithpublishUrl. - Changes
CompositionClient.registerRtmpInputto return the RTMP publish URL and throw if the server omits it. - Updates/extends Composition client tests to cover the new response shape and the missing-URL error case.
File summaries
| File | Description |
|---|---|
| packages/js-server-sdk/tests/composition.test.ts | Updates serialization expectations and adds tests for registerRtmpInput returning/throwing based on publish_url. |
| packages/js-server-sdk/src/composition.ts | Makes registerRtmpInput return publishUrl and throw UnknownException when absent. |
| packages/composition-openapi/src/generated/models/RegisterInputResponse.ts | Regenerated OpenAPI model mapping publish_url ⇄ publishUrl (replacing port). |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Karolk99
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The composition API now reports a complete RTMP publish URL where it previously reported only a port.
RegisterInputResponse.portis replaced bypublishUrlregisterRtmpInputreturns the publish URL instead ofvoid, throwing when the server omits itMotivation and Context
The publish address can no longer be derived from the composition origin and a port, so the server supplies the whole URL.
Documentation impact
Types of changes