feat(examples): background blur on the Fishjam camera track - #608
Closed
MiloszFilimowski wants to merge 3 commits into
Closed
MiloszFilimowski wants to merge 3 commits into
MiloszFilimowski wants to merge 3 commits into
Conversation
fishjam-chat and minimal-react apply @fishjam-cloud/video-effects through useFishjamCameraEffect, on the camera track useCamera publishes.
Vite pre-bundles video-effects, so the package's default model path resolves relative to the bundled chunk and misses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires background blur into both examples with the released packages. The app code is two hooks:
BlurCameraProviderowns the toggle and calls the hooks; a blur button on the preview and room screens. Dependencies:@fishjam-cloud/video-effects0.1.1,@fishjam-cloud/react-native-worklets0.12.1,react-native-webgpu. Babel gets the TypeGPU and worklets plugins; Metro learns the.ssgbinmodel asset and pins the native modules to one copy.@fishjam-cloud/video-effects/fishjam-react, with a blur toggle.Based on #607 (Expo 57, required by react-native-worklets 0.12). Needs #606 (react-client middleware re-apply) for the effect to attach when it is enabled before the camera starts.
Verification on a Galaxy S23 and in Chrome follows on this PR.
https://claude.ai/code/session_01FWRoR5MneE6GE9crQ9tF6W