fix(labels): correct entity label to use entity data instead of stale waypoint/order fallbacks#280
Open
janni1288 wants to merge 1 commit into
Open
Conversation
… waypoint/order fallbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the entity label template ('entity-label.php'), which was copy-pasted from 'waypoint-label.php' and still referenced '$waypoint'/'$order', variables that are never passed to 'Entity::label()'.
Why
Related to #182 - while investigating single-entity label generation, found that the existing 'type=entity' label endpoint renders a broken title ("Waypoint Label" instead of the correct label) and contains dead/unreachable fallback code ('$order->trackingNumber') that would throw if '$trackingNumber' were never empty.
Changes
Testing
Related to #182