docs(v2): health and readiness probes in Kubernetes deployment guide - #421
Merged
Merged
Conversation
Adds a "Health and Readiness Probes" section to the Deploy to Kubernetes guide covering the generic liveness check (/health) and the per-service readiness checks (management, evaluation) over gRPC and HTTP, plus livenessProbe/readinessProbe examples and why readiness must gate on the evaluation service. Closes #420 Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: approve
Clean, accurate addition to the v2 Kubernetes deployment guide. The health/readiness content checks out: ports (8080 HTTP / 9000 gRPC), the gRPC Health Checking Protocol status values, the empty-service liveness vs. per-service readiness distinction, and the /health?service= query param all match Flipt's documented behavior, and both relative links resolve. The previous review's nit (a redundant "Value" table column) has been addressed — the table now uses only "Service" + "Meaning". No changes requested.
🤖 Automated review by the Flipt PR review agent.
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Health and Readiness Probes" section to the Deploy to Kubernetes
guide covering the generic liveness check (/health) and the per-service
readiness checks (management, evaluation) over gRPC and HTTP, plus
livenessProbe/readinessProbe examples and why readiness must gate on
the evaluation service.
closes #420