fix: write and read back partitioned datasets - #2626
Merged
Merged
Conversation
- parquet: openForWrite() returns a per-file ParquetFileWriter - parquet: path-only partition columns left out of the file schema - parquet: PHP engine splits array batches into row groups - etl: a failed closure() discards every staged file - filesystem: one glob matcher for local, memory, S3 and Azure - filesystem: webmozart/glob removed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2626 +/- ##
============================================
+ Coverage 84.39% 84.40% +0.01%
- Complexity 29844 29865 +21
============================================
Files 1992 1996 +4
Lines 86544 86539 -5
============================================
+ Hits 73036 73042 +6
+ Misses 13508 13497 -11 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/parquet-ParquetFileWriter, one independent writer per fileflow-php/filesystem-GlobPatternmatcher andGlobWalkerlocal walkFixed
flow-php/etl-adapter-parquet- path-only partition columns left out of the file schemaflow-php/parquet- writers sharing one engine no longer overwrite each otherflow-php/parquet- a writer whose close throws stays closedflow-php/parquet- PHP engine splits array batches into row groupsflow-php/parquet- rows keep their order when writeRow() precedes writeBatch()flow-php/etl- a failed closure() leaves no staged file behindflow-php/filesystem- local, memory, S3 and Azure list the same files for a globChanged
flow-php/parquet-ParquetEngine::openForWrite()returns aParquetFileWriterflow-php/filesystem- glob wildcards match dotfiles; a double star inside a name acts as a single starflow-php/etl-adapter-parquet- path-only partition columns read back as string unless declaredRemoved
flow-php/parquet-ParquetEngine::closeWrite(),writeBatch(),writeRow()flow-php/filesystem-webmozart/globdependencyDeprecated
Security