fix: report release tag or commit as extension version - #2632
Merged
Merged
Conversation
- arrow, flow_php and pg_query resolve version from env, release archive or git describe - untagged builds report semver build metadata, e.g. 0.43.0+107.gf998a45d0 - PIE CI jobs install from git archive and assert phpversion()
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2632 +/- ##
============================================
- Coverage 84.44% 84.43% -0.02%
Complexity 30003 30003
============================================
Files 2005 2005
Lines 86857 86857
============================================
- Hits 73347 73335 -12
- Misses 13510 13522 +12 🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: de24fcd | Docs | View more details | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
flow-php/arrow-ext- extension reports release tag or commit instead of hardcoded 0.1.0flow-php/flow-php-ext- extension reports release tag or commit instead of hardcoded 0.3.0flow-php/pg-query-ext- extension reports release tag or commit instead of hardcoded 0.1.0Changed
flow-php/arrow-ext- build fails when no version source is availableflow-php/flow-php-ext- build fails when no version source is availableflow-php/pg-query-ext- build fails when no version source is availableRemoved
Deprecated
Security