Skip to content

docs: align Playwright and engineio version references - #92

Merged
flowcool merged 1 commit into
playwright-nextfrom
fix/compatible-deps86-hvwxk
Nov 2, 2026
Merged

flowcool merged 1 commit into
playwright-nextfrom
fix/compatible-deps86-hvwxk

Conversation

@flowcool

@flowcool flowcool commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Behavior

After dependency PR #86, the recipe method contract and adapter proof guide still named Playwright 1.64.0. They now name the installed pin, 1.64.1. The engineio workaround comment names 4.15.0 and no longer claims that it is the latest version.

This completes the nonblocking observation in Pullfrog's PR #86 review. Only documentation and one Python comment change.

Verification

  • Compare ast.dump(ast.parse(...)) for apps/billcollector/ui/app.py before and after: identical.
  • Ruff 0.17.3 and git diff --check: pass.
  • Two method-contract references and one adapter-guide reference now match apps/requirements.txt.
  • PR fix: refresh dependencies with a compatible pyee pin #86 already passed the complete synthetic suite and image qualification. Pullfrog re-derived the five Playwright chain types: 320 public members, zero signature differences between 1.64.0 and 1.64.1.

No executable behavior or recipe example changes. CI must pass on this head.

Infra handoff

N/A: documentation/comment maintenance. No schema, database, runtime configuration or deployment change. Rollback is a focused revert.

AI assistance

Codex corrected the references, reviewed the complete diff, checked Python AST equivalence and ran Ruff.

Pullfrog review

Require a completed final-head review and green CI. Review evidence: completed Pullfrog review of 5cb5530ae6d1ba6d9f29c8166b44c779853594d7, no new issues and no unresolved threads. Required CI is green. pr-ship merged the reviewed head at fffae499d26857f8259c8461a315e1079548e73c.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • docs:
  • docs(

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the single commit, which updates version references left stale after dependency PR #86.

  • Playwright pin in doc/RECIPE_METHODS.md — both playwright==1.64.0 mentions (method contract and §6 change control) now say 1.64.1, matching apps/requirements.txt. No other 1.64.0 reference remains in the repo.
  • Browser-cache note in doc/BOURSE_DIRECT_ADAPTER.md — the isolated engine proof now names Playwright 1.64.1.
  • engineio workaround comment in apps/billcollector/ui/app.py — now names the pinned python-engineio==4.15.0 and drops "(latest)". Dropping it was the right call: PyPI already has 4.15.1. I checked the 4.15.0 wheel: translate_request still returns {} for a first event other than http.request/websocket.connect, and AsyncServer.handle_request still indexes environ['REQUEST_METHOD'] without checking it. The comment's claim holds.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@flowcool
flowcool merged commit fffae49 into playwright-next Nov 2, 2026
12 checks passed
@flowcool
flowcool deleted the fix/compatible-deps86-hvwxk branch November 2, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant