Repository navigation
docs: align Playwright and engineio version references - #92
Merged
Merged
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the single commit, which updates version references left stale after dependency PR #86.
- Playwright pin in
doc/RECIPE_METHODS.md— bothplaywright==1.64.0mentions (method contract and §6 change control) now say1.64.1, matchingapps/requirements.txt. No other1.64.0reference remains in the repo. - Browser-cache note in
doc/BOURSE_DIRECT_ADAPTER.md— the isolated engine proof now names Playwright 1.64.1. - engineio workaround comment in
apps/billcollector/ui/app.py— now names the pinnedpython-engineio==4.15.0and drops "(latest)". Dropping it was the right call: PyPI already has 4.15.1. I checked the 4.15.0 wheel:translate_requeststill returns{}for a first event other thanhttp.request/websocket.connect, andAsyncServer.handle_requeststill indexesenviron['REQUEST_METHOD']without checking it. The comment's claim holds.
claude-opus-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Behavior
After dependency PR #86, the recipe method contract and adapter proof guide still named Playwright 1.64.0. They now name the installed pin, 1.64.1. The engineio workaround comment names 4.15.0 and no longer claims that it is the latest version.
This completes the nonblocking observation in Pullfrog's PR #86 review. Only documentation and one Python comment change.
Verification
ast.dump(ast.parse(...))forapps/billcollector/ui/app.pybefore and after: identical.git diff --check: pass.apps/requirements.txt.No executable behavior or recipe example changes. CI must pass on this head.
Infra handoff
N/A: documentation/comment maintenance. No schema, database, runtime configuration or deployment change. Rollback is a focused revert.
AI assistance
Codex corrected the references, reviewed the complete diff, checked Python AST equivalence and ran Ruff.
Pullfrog review
Require a completed final-head review and green CI. Review evidence: completed Pullfrog review of
5cb5530ae6d1ba6d9f29c8166b44c779853594d7, no new issues and no unresolved threads. Required CI is green.pr-shipmerged the reviewed head atfffae499d26857f8259c8461a315e1079548e73c.