fix: port standalone display safety to contribution staging by flowcool · Pull Request #24 · flowcool/Smart_Plant

flowcool · 2026-10-20T19:12:31Z

Behavior

Port the standalone safety follow-up requested in upstream PR29 (infra-3rr.58), already delivered on fork V2R1 in PR18. Missing and nonfinite readings show --; numeric readings stay raw while needles/icons clamp. Boot runs after display setup. A shared recovery timer bounds BUSY retries and reaches the emergency sleep action without another refresh.

Target: flowcool/Smart_Plant:upstream/staging-v2r1, base 4fccab1989a4c1f12022dadbbc34cc36ecdc04fc, source 408de7b. This does not publish to JGAguado or deploy firmware. Both normal and fault sleep retain explicit OTA image confirmation and native shutdown hooks. The 30.510s bound plus scheduling ends at the sleep action, not physical sleep.

Verification

python3 -B -m unittest discover -s tests -v: 49 tests pass, including actual renderer UBSan/extreme values and actual-YAML BUSY scenarios.
All 8 tracked YAML files parse. Strict Sphinx HTML build passes. git -c core.whitespace=cr-at-eol diff --check passes; existing RST CRLF is preserved.
Complete isolated ESPHome2026.9.0 ESP32-S2 standalone firmware build passes, config hash 0xadf7c688; local font/public image fixtures and synthetic credentials only. This proves compilation, not hardware behavior.
Rollback: revert this isolated PR on staging. No fleet/NAS/shared-builder/MQTT/HA action.

AI assistance

Codex ported the existing reviewed change. The author inspected the source, action ordering, compatibility guard, tests and line endings.

CodeRabbit review

Current-head review and required yaml-syntax must pass before merge. Record review/head in the delivery note. Owner: infra-3rr.64.

Summary by CodeRabbit

Améliorations
- L’affichage de la batterie et des jauges gère désormais les valeurs absentes, invalides ou non finies avec des indicateurs clairs.
- Les jauges et icônes restent dans leurs limites visuelles, tout en conservant la valeur mesurée pour l’étiquette.
- La mise en veille attend désormais la confirmation de l’écran et tente une récupération en cas de blocage avant d’activer une veille de secours.
Documentation
- Ajout d’informations sur la validation des valeurs, le fonctionnement de la mise en veille et la récupération après incident.

coderabbitai · 2026-10-20T19:12:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 142e55a9-f247-4c7f-8adf-36e54c9f9db0

📥 Commits

Reviewing files that changed from the base of the PR and between 4fccab1 and 408de7b.

📒 Files selected for processing: 4

docs/source/files/configuration.yaml
docs/source/programming.rst
tests/display_automation.py
tests/test_standalone_display.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📜 Recent review details

🧰 Additional context used

📚 Code guidelines: 3

.claude/rules/esphome-yaml.md — auto-discovered
.claude/rules/nas-operations.md — auto-discovered
AGENTS.md — auto-discovered

📓 Path-based instructions: 3

Source excerpt: `use_address` must be in the `wifi:` block of the device YAML, not only in `substitutions:` — the ESPHome CLI reads YAML without resolving packages.

📄 CodeRabbit inference engine (.claude/rules/esphome-yaml.md)

Files:

docs/source/files/configuration.yaml

Source excerpt: ESPHome's native guard (`>=2026.8.0`) confirms the app image on any orderly `deep_sleep.enter`, so a short measurement cycle is no longer misclassified as a failed OTA boot; `smart_plant_core.yaml` no longer calls `safe_mode...

📄 CodeRabbit inference engine (.claude/rules/nas-operations.md)

Files:

docs/source/files/configuration.yaml

Source excerpt: Parse changed YAML and run `git diff --check`; inspect both `git diff --numstat` and the semantic diff before committing.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

docs/source/files/configuration.yaml

🪛 ast-grep (0.45.3)

tests/display_automation.py

[warning] 32-32: avoid deserializing untrusted YAML
Context: yaml.load((Path(root) / "docs/source/files/configuration.yaml").read_text(), PackageLoader)
Note: [CWE-502] Deserialization of Untrusted Data.

(yaml-load)

[warning] 36-36: avoid deserializing untrusted YAML
Context: yaml.load((packages / "smart_plant_core.yaml").read_text(), PackageLoader)
Note: [CWE-502] Deserialization of Untrusted Data.

(yaml-load)

[warning] 37-39: avoid deserializing untrusted YAML
Context: yaml.load(
(packages / f"smart_plant_profile_{profile}.yaml").read_text(), PackageLoader
)
Note: [CWE-502] Deserialization of Untrusted Data.

(yaml-load)

tests/test_standalone_display.py

[warning] 54-54: avoid deserializing untrusted YAML
Context: yaml.load(PUBLIC.read_text(), PackageLoader)
Note: [CWE-502] Deserialization of Untrusted Data.

(yaml-load)

[error] 62-63: Command coming from incoming request
Context: subprocess.run(["c++", "-std=c++20", "-fsanitize=undefined,float-cast-overflow",
"-fno-sanitize-recover=all", str(source), "-o", str(cls.executable)], check=True)
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').

(subprocess-from-request)

[error] 68-68: Command coming from incoming request
Context: subprocess.run([str(self.executable), *args], check=True, text=True, capture_output=True)
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').

(subprocess-from-request)

[warning] 127-127: avoid deserializing untrusted YAML
Context: yaml.load(PUBLIC.read_text(), PackageLoader)
Note: [CWE-502] Deserialization of Untrusted Data.

(yaml-load)

🪛 OpenGrep (1.30.1)

tests/display_automation.py

[ERROR] 32-32: yaml.load() without SafeLoader can execute arbitrary Python code. Use yaml.safe_load() or yaml.load(..., Loader=SafeLoader) instead.