Repository navigation
fix: restore missing KiCad library from schematic caches - #30
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 4
✨ Finishing Touches
Comment |
Owner
Author
|
@coderabbitai review |
|
flowcool
added a commit
that referenced
this pull request
Oct 21, 2026
Protect low batteries with persistent hysteresis and long sleep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Port the source recovery from fork PR #12. Restore the library of 28 symbols local library referenced by the existing schematics. Preserve body tokens, geometry, pins and properties; reject conflicting cache definitions or unresolved references. Schematics/PCB/manufacturing files are unchanged.
Target: flowcool/Smart_Plant:upstream/staging-v2r1. Source
f426584, predecessor713b8cc. Open after the preceding contribution merges so this PR contains only its owned change. The upstream baseline isbcf373144b2d5c7e3a712fd02698e2e98e45aeed. No PR to JGAguado is authorized.Verification
python3 scripts/recover_kicad_symbol_library.py --check passes. Four deterministic tests verify exact source recovery, parser boundaries, cache conflict and reference coverage. Native KiCad 10/ERC is unverified: installed KiCad 9.0.2 cannot validate format 20251024. No fabrication or electrical validation is claimed.
Inspect the semantic diff and
git -c core.whitespace=cr-at-eol diff --check; preserve existing line endings. All tracked YAML parses. Firmware fixtures use local fonts/public images and synthetic credentials, never devices or shared builders. Local compilation does not prove deployment.Rollback: revert this isolated PR on staging. No automatic deployment, fleet/NAS/cache purge/MQTT/HA action.
AI assistance
Codex prepared the port or extraction. The author inspected the behavior, contribution boundary, actual-source tests, compatibility and diff. Existing staging OTA confirmation and native shutdown remain intact.
CodeRabbit review
Require current-head completed review and yaml-syntax before merge. Florent approved one manual review request per ignored PR for this series only. Documentation-only PRs use the standing docs gate. Record review/head/checks/merge in owner
infra-3rr.70.Summary by CodeRabbit
Nouvelles fonctionnalités
Documentation
Tests