Skip to content

fix: restore missing KiCad library from schematic caches - #30

Merged
flowcool merged 1 commit into
upstream/staging-v2r1from
upstream/kicad-symbol-library
Oct 20, 2026
Merged

flowcool merged 1 commit into
upstream/staging-v2r1from
upstream/kicad-symbol-library

Conversation

@flowcool

@flowcool flowcool commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Behavior

Port the source recovery from fork PR #12. Restore the library of 28 symbols local library referenced by the existing schematics. Preserve body tokens, geometry, pins and properties; reject conflicting cache definitions or unresolved references. Schematics/PCB/manufacturing files are unchanged.

Target: flowcool/Smart_Plant:upstream/staging-v2r1. Source f426584, predecessor 713b8cc. Open after the preceding contribution merges so this PR contains only its owned change. The upstream baseline is bcf373144b2d5c7e3a712fd02698e2e98e45aeed. No PR to JGAguado is authorized.

Verification

python3 scripts/recover_kicad_symbol_library.py --check passes. Four deterministic tests verify exact source recovery, parser boundaries, cache conflict and reference coverage. Native KiCad 10/ERC is unverified: installed KiCad 9.0.2 cannot validate format 20251024. No fabrication or electrical validation is claimed.

Inspect the semantic diff and git -c core.whitespace=cr-at-eol diff --check; preserve existing line endings. All tracked YAML parses. Firmware fixtures use local fonts/public images and synthetic credentials, never devices or shared builders. Local compilation does not prove deployment.

Rollback: revert this isolated PR on staging. No automatic deployment, fleet/NAS/cache purge/MQTT/HA action.

AI assistance

Codex prepared the port or extraction. The author inspected the behavior, contribution boundary, actual-source tests, compatibility and diff. Existing staging OTA confirmation and native shutdown remain intact.

CodeRabbit review

Require current-head completed review and yaml-syntax before merge. Florent approved one manual review request per ignored PR for this series only. Documentation-only PRs use the standing docs gate. Record review/head/checks/merge in owner infra-3rr.70.

Summary by CodeRabbit

  • Nouvelles fonctionnalités

    • Ajout d’un outil permettant de reconstruire et de vérifier automatiquement la bibliothèque de symboles KiCad.
    • Détection des symboles manquants, des conflits entre caches et des références non résolues.
    • Prise en charge d’un mode de vérification sans modification des fichiers.
  • Documentation

    • Documentation ajoutée sur la récupération de la bibliothèque, ses 28 symboles, les commandes disponibles et les limites de validation.
  • Tests

    • Ajout de contrôles couvrant l’intégrité des symboles, les échappements, les parenthèses et les erreurs d’entrée.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9a818719-aa5e-48f0-a41f-0d5a5ebe7ef3
📥 Commits

Reviewing files that changed from the base of the PR and between d16e97d and f426584.

📒 Files selected for processing: 4
  • Design/Smart_Plant-eagle-import.kicad_sym
  • docs/kicad-symbol-recovery.md
  • scripts/recover_kicad_symbol_library.py
  • tests/test_kicad_symbol_library.py
+-------------------------------+
| The only circle I like is CI. |
+-------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@flowcool

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request base or head changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@flowcool
flowcool merged commit 6901f24 into upstream/staging-v2r1 Oct 20, 2026
1 of 2 checks passed
@flowcool
flowcool deleted the upstream/kicad-symbol-library branch October 20, 2026 19:58
flowcool added a commit that referenced this pull request Oct 21, 2026
Protect low batteries with persistent hysteresis and long sleep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant