Skip to content

ci: restore the labeled trigger on PR release labels - #135

Merged
flowcool merged 1 commit into
mainfrom
ci/restore-labeled
Oct 27, 2026
Merged

flowcool merged 1 commit into
mainfrom
ci/restore-labeled

Conversation

@flowcool

Copy link
Copy Markdown
Owner

Behavior

Follow-up to #133. That PR removed the labeled trigger from PR release labels on the assumption that the workflow re-triggered on its own label writes. Labels written with GITHUB_TOKEN never trigger workflows, so the removal saved nothing and dropped the Release impact re-check when breaking-change or compat is added by hand (finding from the Pullfrog review of the sibling boursedirect-sync PR). This restores the original trigger list.

Release impact

None. CI only.

Verification

AI assistance

Prepared by Claude Code (Opus 5.5).

🤖 Generated with Claude Code

https://claude.ai/code/session_01EQXdcx49Pi5uQErd6kDEKs

GITHUB_TOKEN label writes never trigger workflows, so removing labeled saved
nothing; it re-checks Release impact when breaking-change or compat is added
by hand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EQXdcx49Pi5uQErd6kDEKs
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the maintenance Dependencies, CI, chores label Oct 27, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the single-commit diff to .github/workflows/pr-release-labels.yml.

  • Restored labeled trigger — pull_request.types is back to [opened, edited, reopened, labeled], so a hand-added breaking-change or compat label re-runs the Release impact check.

Verified against scripts/label_pr_release.py: main() builds current from pr["labels"] in the event payload, which on a labeled event includes the newly added label, so the impact warning evaluates correctly. Labels the script writes with GITHUB_TOKEN do not trigger workflows, so there is no re-trigger loop. The script is advisory and always returns 0, and the job keeps minimal permissions with a pinned checkout, so the change adds no required-check or secret exposure concerns.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@flowcool
flowcool merged commit 2b7b032 into main Oct 27, 2026
13 checks passed
@flowcool
flowcool deleted the ci/restore-labeled branch October 27, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Dependencies, CI, chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant