Repository navigation
ci: restore the labeled trigger on PR release labels - #325
Merged
Merged
Conversation
GITHUB_TOKEN label writes never trigger workflows, so removing labeled saved nothing; it re-checks Release impact when breaking-change or compat is added by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EQXdcx49Pi5uQErd6kDEKs
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the single-commit change to the PR release labels workflow trigger.
- Restore
labeledtrigger:.github/workflows/pr-release-labels.ymlgoes back totypes: [opened, edited, reopened, labeled]. The change is safe:scripts/label_pr_release.pyreads current labels from the event payload and only adds missing ones, and labels written withGITHUB_TOKENdon't re-trigger workflows, so there is no loop. The per-PRconcurrencygroup still collapses overlapping runs.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Behavior
Follow-up to #324. That PR removed the
labeledtrigger fromPR release labelson the assumption that the workflow re-triggered on its own label writes. Labels written withGITHUB_TOKENnever trigger workflows, so the removal saved nothing and dropped theRelease impactre-check whenbreaking-changeorcompatis added by hand (finding from the Pullfrog review of the sibling boursedirect-sync PR). This restores the original trigger list.Release impact
None. CI only.
Verification
git diff origin/main~1 -- .github/workflows/pr-release-labels.ymlbefore ci: cut CI and review-bot cost; one PR per change #324types: [opened, edited, reopened, labeled].AI assistance
Prepared by Claude Code (Opus 5.5).
🤖 Generated with Claude Code
https://claude.ai/code/session_01EQXdcx49Pi5uQErd6kDEKs