Repository navigation
fix(ci): install native release checker dependencies - #329
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: the single workflow change in .github/workflows/release-image.yml.
- Install checker dependencies in native build jobs — adds
pip install --require-hashes -r requirements.txtaftersetup-python, soscripts/check_container_runtime.shcan importrelease_image.py, which importsrequestsat top level. The step runs before the runtime check, andrequirements.txtpinsrequestswith hashes. It matches the install line already used in the preflight and other jobs of this workflow.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Behavior
Native RC builds failed before image publication because the host runtime check imported
release_image.pywithout itsrequestsdependency. Install the exact hashed runtime requirements after Python setup in both native build jobs. The existing image identity and isolated runtime checks can then run.Release impact
Release tooling fix for v4.0.0. No runtime behavior or shared Ghostfolio helper changed. The failed rc.1 has no published image digest and cannot qualify. A new immutable RC includes this workflow fix. Reverting the workflow requires another RC; published candidates cannot be overwritten. PR #328 owns the implementation.
Verification
bash -n scripts/check_container_runtime.shandgit diff --checkpass.AI assistance
Codex prepared the change. The author checked the exact rc.1 failure on both runners, dependency hashes, semantic diff, required CI and Pullfrog review.
Pullfrog review
Completed on final head 549905f. No issue or unresolved thread. Merged through pr-ship as 72fb74a.
Review evidence: #329 (review)