Skip to content

fix(ci): install native release checker dependencies - #329

Merged
flowcool merged 1 commit into
mainfrom
fix/rc-native-runtime-check
Oct 28, 2026
Merged

flowcool merged 1 commit into
mainfrom
fix/rc-native-runtime-check

Conversation

@flowcool

@flowcool flowcool commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Behavior

Native RC builds failed before image publication because the host runtime check imported release_image.py without its requests dependency. Install the exact hashed runtime requirements after Python setup in both native build jobs. The existing image identity and isolated runtime checks can then run.

Release impact

Release tooling fix for v4.0.0. No runtime behavior or shared Ghostfolio helper changed. The failed rc.1 has no published image digest and cannot qualify. A new immutable RC includes this workflow fix. Reverting the workflow requires another RC; published candidates cannot be overwritten. PR #328 owns the implementation.

Verification

  • Command: required PR CI, including native AMD64 and ARM64 container checks.
  • Expected result: the checker imports its pinned dependencies and validates both images.
  • Observed result: all required checks pass on 549905f. The rc.2 build also passed both native checks and publication: https://github.com/flowcool/ghostfolio-ibkr-sync/actions/runs/40698337401.
  • bash -n scripts/check_container_runtime.sh and git diff --check pass.

AI assistance

Codex prepared the change. The author checked the exact rc.1 failure on both runners, dependency hashes, semantic diff, required CI and Pullfrog review.

Pullfrog review

Completed on final head 549905f. No issue or unresolved thread. Merged through pr-ship as 72fb74a.

Review evidence: #329 (review)

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the fix Bug fix label Oct 28, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the single workflow change in .github/workflows/release-image.yml.

  • Install checker dependencies in native build jobs — adds pip install --require-hashes -r requirements.txt after setup-python, so scripts/check_container_runtime.sh can import release_image.py, which imports requests at top level. The step runs before the runtime check, and requirements.txt pins requests with hashes. It matches the install line already used in the preflight and other jobs of this workflow.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@flowcool
flowcool merged commit 72fb74a into main Oct 28, 2026
15 checks passed
@flowcool
flowcool deleted the fix/rc-native-runtime-check branch October 28, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant